Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy hypergrid #5

Merged
merged 18 commits into from
Jan 7, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check for console.error() in tests.
  • Loading branch information
texodus committed Jan 5, 2018
commit d7d868102f7ba698518ba61b17520de0da2b04e9
5 changes: 4 additions & 1 deletion packages/perspective-viewer/test/js/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ test.capture = function capture(name, body, timeout = 60000) {
if (process.env.DEBUG) private_console.log("---- " + name + " -----------------------------");
const page = await browser.newPage();
page.on('console', msg => {
if (msg.type === 'error') {
errors.push(msg.message);
}
if (process.env.DEBUG) {
private_console.log(msg.text);
}
Expand All @@ -147,7 +150,7 @@ test.capture = function capture(name, body, timeout = 60000) {

// let animation run;
await page.waitForSelector('perspective-viewer:not([updating])');
await page.waitFor(300);
await page.waitFor(500);

const screenshot = await page.screenshot();
await page.close();
Expand Down