Empty filters #387
Merged
Empty filters #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! While this is most certainly more correct, the issue is a bit complex - users should be able to do anything that developers can do wrt data transforms, eg filter on datasets with empty string values - and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#349 #375 Prior to my pull request for invalid filters, I've had a slight re-think of my implementation. My implementation resulted in empty strings being invalid filter operands. Although this makes sense for the viewer component, it doesn't seem to be appropriate for those using Perspective without the viewer. Therefore, I've pulled the check for empty strings into the viewer and updated the tests as necessary.