Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-compiled JavaScript artifacts for Perspective package #378

Closed
wants to merge 25 commits into from
Closed

Add pre-compiled JavaScript artifacts for Perspective package #378

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
6b82083
use babel compiled assets rather than raw assets when building perspe…
LukeSheard Jan 12, 2019
67fb588
correct output directory for babel and gitignore
LukeSheard Jan 12, 2019
88eab9e
adjust core build entrypoints to account for the new asset location
LukeSheard Jan 12, 2019
391e335
move webpack-plugin into separate package
LukeSheard Jan 12, 2019
6422881
shift dependencies to where they're needed
LukeSheard Jan 12, 2019
fe67e4b
move core-js back to devDependencies
LukeSheard Jan 12, 2019
d6f48eb
make sure babel runs over code which is not precompiled during intern…
LukeSheard Jan 12, 2019
4c7dba1
fix lint
LukeSheard Jan 12, 2019
a90bf0c
fix issues with importing babel config
LukeSheard Jan 12, 2019
1b19470
fix issues with options validation
LukeSheard Jan 12, 2019
bf7c29e
update perspecrive package entrypoint
LukeSheard Jan 12, 2019
6987434
fix jupyterlab build
LukeSheard Jan 12, 2019
16adf83
fix lint
LukeSheard Jan 12, 2019
3981ba8
undo cpp lint fix changes
LukeSheard Jan 13, 2019
19b6362
undo less lint fix
LukeSheard Jan 13, 2019
338ef31
fix perspective-viewer example and add cjs format into package
LukeSheard Jan 19, 2019
e03c7da
add commonjs build for viewer modules
LukeSheard Jan 19, 2019
4316e77
remove unncessary loaders from jupyterlab plugin
LukeSheard Jan 19, 2019
785cace
add viewer plugins into example
LukeSheard Jan 19, 2019
8c22965
Merge branch 'master' into babel-compile
LukeSheard Jan 19, 2019
5759d77
remove cross imports from modules
LukeSheard Jan 19, 2019
eb2b374
move loader code into webpack-plugin
LukeSheard Jan 19, 2019
5644ba1
add parameters to webpack plugin to allow overriding options as a user
LukeSheard Jan 19, 2019
5b69eb6
Apply default options in the correct order
LukeSheard Jan 19, 2019
9de93af
tweak logic for CORS file loading in a webpack world
LukeSheard Jan 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unncessary loaders from jupyterlab plugin
  • Loading branch information
@LukeSheard
LukeSheard committed Jan 19, 2019
commit 4316e77e3b8203e6c569402e6a601af065a41f09
13 changes: 0 additions & 13 deletions packages/perspective-jupyterlab/src/config/plugin.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ module.exports = {
rules: [
{
LukeSheard marked this conversation as resolved.
Show resolved Hide resolved
test: /\.less$/,
exclude: /themes/,
use: [
{
loader: "css-loader"
Expand All @@ -43,18 +42,6 @@ module.exports = {
}
]
},
{
test: /\.(html)$/,
loader: "html-loader"
},
{
test: /\.(arrow)$/,
loader: "arraybuffer-loader"
},
{
test: /\.css$/,
use: [{loader: "css-loader"}]
},
{
LukeSheard marked this conversation as resolved.
Show resolved Hide resolved
test: /\.ts?$/,
loader: "ts-loader"
Expand Down
4 changes: 2 additions & 2 deletions packages/perspective-viewer-highcharts/src/config/highcharts.plugin.cjs.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ module.exports = Object.assign({}, common({no_minify: true}), {
externals: [
function(context, request, callback) {
for (let external of externals) {
if (external.test(request)){
return callback(null, 'commonjs ' + request);
if (external.test(request)) {
return callback(null, "commonjs " + request);
}
}
callback();
Expand Down
4 changes: 2 additions & 2 deletions packages/perspective-viewer-hypergrid/src/config/hypergrid.plugin.cjs.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ module.exports = Object.assign({}, common({no_minify: true}), {
externals: [
function(context, request, callback) {
for (let external of externals) {
if (external.test(request)){
return callback(null, 'commonjs ' + request);
if (external.test(request)) {
return callback(null, "commonjs " + request);
}
}
callback();
Expand Down
4 changes: 2 additions & 2 deletions packages/perspective-viewer/src/config/view.cjs.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ module.exports = Object.assign({}, common({no_minify: true}), {
externals: [
function(context, request, callback) {
for (let external of externals) {
if (external.test(request)){
return callback(null, 'commonjs ' + request);
if (external.test(request)) {
return callback(null, "commonjs " + request);
}
}
callback();
Expand Down