Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build & performance fixes #353

Merged
merged 14 commits into from
Jan 2, 2019
Merged

Build & performance fixes #353

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
aeb040b
Fixed axis-reversal bug in y_acatter chart, and enabled boost mode fo…
texodus Dec 24, 2018
548b223
Fixed master branch benchmarking, and reversed benchmark version order
texodus Dec 24, 2018
16b528a
Enabled closure compiler for emscripten output
texodus Dec 24, 2018
6294c5d
Toss first iterations from benchmarks
texodus Dec 27, 2018
fba010e
Added JSON load benchmarks
texodus Dec 28, 2018
b0996f8
Removed Jasmine
texodus Dec 28, 2018
9dedd28
Removed test compilation
texodus Dec 28, 2018
8ff9557
Fixed heatmap test failure
texodus Dec 28, 2018
f25bdb9
Reduced verbosity of build failures
texodus Dec 30, 2018
ef4a94b
Improve JSON parsing speed by ~20%
texodus Dec 30, 2018
e6d227a
Fixed test suite
texodus Dec 30, 2018
2f8b1d3
Format
texodus Dec 31, 2018
ad11fd7
Fix for remove() test failure
texodus Jan 2, 2019
4b7a44c
Better debug messaging
texodus Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix for remove() test failure
  • Loading branch information
@texodus
texodus committed Jan 2, 2019
commit ad11fd7b9f785a780877d71710fd95d1c911d669
5 changes: 3 additions & 2 deletions packages/perspective/src/js/perspective.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,6 +1151,7 @@ export default function(Module) {
*/
table.prototype.remove = function(data) {
let pdata;
let cols = this._columns();
let schema = this.gnode.get_tblschema();
let types = schema.types();
let is_arrow = false;
Expand All @@ -1163,15 +1164,15 @@ export default function(Module) {
} else {
accessor.init(__MODULE__, data);
accessor.names = [this.index];
accessor.types = accessor.extract_typevec(types);
accessor.types = [accessor.extract_typevec(types)[cols.indexOf(this.index)]];
pdata = accessor;
}

try {
[, this.limit_index] = make_table(pdata, this.pool, this.gnode, undefined, this.index || "", this.limit, this.limit_index, false, true, is_arrow);
this.initialized = true;
} catch (e) {
console.error(`Remove failed: ${e}`);
console.error(`Remove failed`, e);
} finally {
schema.delete();
types.delete();
Expand Down