Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pyodide support and split Rust/C++ builds for Python wheel #2679

Closed
wants to merge 1 commit into from
Closed

Add Pyodide support and split Rust/C++ builds for Python wheel #2679

wants to merge 1 commit into from

Conversation

timbess
Copy link
Contributor

@timbess timbess commented Jul 16, 2024 •
edited
Loading

This PR does the following:

  • Adds Pyodide support by splitting Rust & C++ and linking them within Python (linking Rust and C++ directly seemed to lead to weird errors in indirect function call offsets at runtime).
  • Unifies the Python and JS binding to use the same translation unit (binding_api.cpp).
  • Refactors the binding API to be in terms of packed C structs over the manual malloc + pointer arithmetic.

@timbess timbess force-pushed the psp-3.0-rust-cxx-split-v2 branch 26 times, most recently from ca00a93 to 2fa8179 Compare July 17, 2024 20:55
@texodus texodus added this to the 3.0 milestone Jul 18, 2024
@timbess timbess force-pushed the psp-3.0-rust-cxx-split-v2 branch 3 times, most recently from 71fe4de to b7d6655 Compare July 18, 2024 17:36
@timbess timbess force-pushed the psp-3.0-rust-cxx-split-v2 branch from e235484 to 395dc0c Compare July 22, 2024 21:54
@texodus texodus mentioned this pull request Jul 24, 2024
Closed
@timbess timbess force-pushed the psp-3.0-rust-cxx-split-v2 branch 8 times, most recently from ea0a4bb to f2e6744 Compare July 25, 2024 20:55
@timbess timbess force-pushed the psp-3.0-rust-cxx-split-v2 branch 11 times, most recently from d61fb36 to cbee65c Compare August 2, 2024 20:49
@timbess timbess force-pushed the psp-3.0-rust-cxx-split-v2 branch 3 times, most recently from 0e97c93 to 170ee7d Compare August 7, 2024 13:32
@timbess
Divorce C++ from Rust Python bindings.
dd209a3 
Signed-off-by: Timothy Bess <tim@prospective.dev>
@timbess timbess force-pushed the psp-3.0-rust-cxx-split-v2 branch from 170ee7d to dd209a3 Compare August 7, 2024 14:28
@texodus texodus mentioned this pull request Aug 14, 2024
Merged
@texodus
Copy link
Member

texodus commented Aug 15, 2024

Fixed in #2707

@texodus texodus closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkpaine timkpaine timkpaine left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timbess @timkpaine @texodus