Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist column settings across plugins #2469

Closed
wants to merge 13 commits into from

Conversation

ada-x64
Copy link
Contributor

@ada-x64 ada-x64 commented Dec 7, 2023

First step in fixing #1610

Based on #2443

This PR moves the datagrid's integer and floating point precision out of the plugin settings and into a new perspective-viewer config field called column_config. This is communicated to the plugin by passing the viewer config to the plugin directly on restore.

CHANGES:

  • Create a column style control abstraction and integrate a precision control for numeric types.
  • Add column_config to the viewer API.
  • Update plugin.restore to accept both the plugin config and the total viewer config, allowing it to access column_config.
  • Integrate the precision control for Datagrid.
  • Add DEFAULT_CONFIG to perspective-viewer exports for use in tests.

TODO:

  • Integrate the new config settings in the datagrid.
  • Write migrations.
  • Write tests.
  • Future PR: Use this to integrate X/Y Scatter Plot axis labelling with column_config precision status.

@ada-x64 ada-x64 force-pushed the features/float-precision branch from 9956cf0 to f6b86e8 Compare December 12, 2023 21:16
@ada-x64 ada-x64 marked this pull request as ready for review December 12, 2023 21:17
@ada-x64
Copy link
Contributor Author

ada-x64 commented Jan 23, 2024

The approach in this PR is not going to work. We need to overhaul a few things.
Superseded by #2508

@ada-x64 ada-x64 closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant