-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist column settings across plugins #2469
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Jakubowski <tom@crystae.net>
add fixture test
ada-x64
force-pushed
the
features/float-precision
branch
from
December 12, 2023 21:16
9956cf0
to
f6b86e8
Compare
update jupyter tests
ada-x64
force-pushed
the
features/float-precision
branch
from
December 26, 2023 16:51
5bc344d
to
19a5b74
Compare
This was referenced Jan 11, 2024
The approach in this PR is not going to work. We need to overhaul a few things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in fixing #1610
Based on #2443
This PR moves the datagrid's integer and floating point precision out of the plugin settings and into a new perspective-viewer config field called
column_config
. This is communicated to the plugin by passing the viewer config to the plugin directly on restore.CHANGES:
column_config
to the viewer API.plugin.restore
to accept both the plugin config and the total viewer config, allowing it to accesscolumn_config
.TODO:
Integrate the new config settings in the datagrid.Write migrations.Write tests.column_config
precision status.