Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve C++/LSP/VSCode Integration #2467

Closed
wants to merge 1 commit into from

Conversation

timbess
Copy link
Contributor

@timbess timbess commented Dec 6, 2023

Improvements to C++ developer experience:

  • Setup ClangD with Emscripten/Python.

Fixes:

  • Fix boost include shadowing local headers.

Before this I was having a hard time getting Intellisense in VSCode to work properly particularly in emscripten.cpp with the calls to code in ./.emsdk in the workspace root. After these changes it works great for me:
image

Also if you build the Python library and open python/perspective in VSCode, pybind and everything works as well:
image

@timbess timbess force-pushed the improve-cpp-experience branch 2 times, most recently from e39ac5e to 1eb3e14 Compare December 6, 2023 19:24
@timbess timbess marked this pull request as ready for review December 6, 2023 19:53
@timbess timbess changed the title Misc Fixes/Improvements Improve C++/LSP/VSCode Integration Dec 6, 2023
@timbess timbess mentioned this pull request Dec 8, 2023
@tomjakubowski
Copy link
Contributor

This works great! Just as a note, when I tried it out, having clangd enabled + configured led to Microsoft's "C/C++" extension outputting a bunch of bogus errors (it looked like it was trying to parse a C++ source file as C). So I disabled that extension in this workspace, just having the clangd extension enabled seems to be fine.

@texodus texodus added the internal Internal refactoring and code quality improvement label Dec 12, 2023
@timbess timbess force-pushed the improve-cpp-experience branch 15 times, most recently from 39128bc to ab80015 Compare December 19, 2023 21:44
@timbess timbess force-pushed the improve-cpp-experience branch from 380374a to b039fce Compare February 21, 2024 21:14
Copy link

finos-cla-bot bot commented Feb 21, 2024

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess).

The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions.

Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

@timbess timbess force-pushed the improve-cpp-experience branch from b039fce to d0f99e7 Compare February 21, 2024 21:16
Copy link

finos-cla-bot bot commented Feb 21, 2024

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess).

The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions.

Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

@timbess timbess force-pushed the improve-cpp-experience branch from d0f99e7 to fe5d0ff Compare February 21, 2024 22:31
Copy link

finos-cla-bot bot commented Feb 21, 2024

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess).

The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions.

Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

@timbess timbess force-pushed the improve-cpp-experience branch from fe5d0ff to 1b1034e Compare February 21, 2024 22:36
Copy link

finos-cla-bot bot commented Feb 21, 2024

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess).

The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions.

Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

@timbess timbess force-pushed the improve-cpp-experience branch from 1b1034e to adb79de Compare February 22, 2024 16:27
Copy link

finos-cla-bot bot commented Feb 22, 2024

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess).

The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions.

Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

@texodus
Copy link
Member

texodus commented Feb 24, 2024

Closing in favor of #2541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants