-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve C++/LSP/VSCode Integration #2467
Conversation
e39ac5e
to
1eb3e14
Compare
This works great! Just as a note, when I tried it out, having clangd enabled + configured led to Microsoft's "C/C++" extension outputting a bunch of bogus errors (it looked like it was trying to parse a C++ source file as C). So I disabled that extension in this workspace, just having the |
39128bc
to
ab80015
Compare
380374a
to
b039fce
Compare
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess). The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions. Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions. |
b039fce
to
d0f99e7
Compare
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess). The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions. Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions. |
d0f99e7
to
fe5d0ff
Compare
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess). The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions. Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions. |
fe5d0ff
to
1b1034e
Compare
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess). The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions. Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions. |
1b1034e
to
adb79de
Compare
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess). The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions. Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions. |
Closing in favor of #2541 |
Improvements to C++ developer experience:
Fixes:
Before this I was having a hard time getting Intellisense in VSCode to work properly particularly in
emscripten.cpp
with the calls to code in./.emsdk
in the workspace root. After these changes it works great for me:Also if you build the Python library and open
python/perspective
in VSCode, pybind and everything works as well: