Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor How Column Style Components Are Selected #2443

Merged
merged 6 commits into from
Dec 31, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix datagrid expression warning
  • Loading branch information
ada-x64 committed Dec 4, 2023
commit 178c1b76cc338c9d6b7960eca18784c5de15ca40
4 changes: 3 additions & 1 deletion packages/perspective-viewer-datagrid/src/js/model/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ export async function createModel(regular, table, view, extend = {}) {
// Extract the entire expression string as typed by the user, so we can
// feed it into `validate_expressions` and get back the data types for
// each column without it being affected by a pivot.
const expressions = config.expressions.map((expr) => expr[1]);
const expressions = Object.fromEntries(
config.expressions.map((expr) => [expr[0], expr[1]])
);
const [
table_schema,
validated_expressions,
Expand Down