Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer QoL fixes #2240

Merged
merged 4 commits into from
May 31, 2023
Merged

Developer QoL fixes #2240

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3c6d91
Better benchmark isolation
texodus May 27, 2023
28e8c7a
Fix node.js runtime error logspam
texodus May 27, 2023
9c38ca7
Fix drag/drop panic
texodus May 27, 2023
52a17a0
Fix test output path
texodus May 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix drag/drop panic
  • Loading branch information
@texodus
texodus committed May 27, 2023
commit 9c38ca7f93009cab2babf9e466e6bdf9d03ac512
8 changes: 4 additions & 4 deletions rust/perspective-viewer/src/rust/components/containers/dragdrop_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,10 @@ where
.iter()
.position(|x| x.1 .1.as_ref().unwrap().props.get_item() == *column);

if let Some(duplicate) = is_duplicate && !ctx.props().allow_duplicates && !is_append {
columns.remove(duplicate);
} else if ctx.props().allow_duplicates && !is_append && is_self_move {
columns.remove(is_duplicate.unwrap());
if let Some(duplicate) = is_duplicate {
if !is_append && (!ctx.props().allow_duplicates || is_self_move) {
columns.remove(duplicate);
}
}

// If inserting into the middle of the list, use
Expand Down