fix cmake build error when install under virtualenv #1777

shinny-chengzhi · 2022-03-31T10:31:55Z

CMake's FindPythonLibs is not working very well under virtualenv. We need to set PYTHON_LIBRARY and PYTHON_INCLUDE_DIR to help CMake locate the relevant directories.

finos-cla-bot · 2022-03-31T10:31:58Z

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@shinny-chengzhi).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

cc @maoo @TheJuanAndOnly99 @mcleo-d

timkpaine

This won't work for manylinux builds, and this stuff is handled by the FindPython cmake modules.

shinny-chengzhi · 2022-04-01T07:47:53Z

It seems like the coding style check failed, and I'm not familiar with Lint Python. Could you shine any light on the error BLK100: Black would make changes?

I think the culprit is the FindPythonLibs module which can't find include&lib location in my case. Here is my setup:

compare python form source and install it to /home/cz/work/python-3.6
create virtualenv under /home/cz/work/py36env
run pip3 install perspective-python and encountered error:

...
  running build_ext
  -- The C compiler identification is GNU 6.3.0
  -- The CXX compiler identification is GNU 6.3.0
  -- Check for working C compiler: /usr/bin/cc
  -- Check for working C compiler: /usr/bin/cc -- works
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Check for working CXX compiler: /usr/bin/c++
  -- Check for working CXX compiler: /usr/bin/c++ -- works
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- Found Boost: /usr/include (found version "1.67.0")
  -- Found Python: /home/cz/work/py36env/bin/python3.6 (found suitable exact version "3.6.5") found components: Interpreter Development
  -- Found PythonInterp: /home/cz/work/py36env/bin/python3.6 (found suitable exact version "3.6.5")
  CMake Error at /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
    Could NOT find PythonLibs (missing: PYTHON_LIBRARIES PYTHON_INCLUDE_DIRS)
    (Required is exact version "3.6")
  Call Stack (most recent call first):
    /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE)
    /usr/share/cmake-3.16/Modules/FindPythonLibs.cmake:310 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
    CMakeLists.txt:377 (find_package)
  
  
  -- Configuring incomplete, errors occurred!
  See also "/tmp/pip-install-ubkztp2d/perspective-python/build/temp.linux-x86_64-3.6/CMakeFiles/CMakeOutput.log".
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-install-ubkztp2d/perspective-python/setup.py", line 259, in <module>
...

Even though I can run python -c "import sysconfig; print(sysconfig.get_config_var('INCLUDEPY'), sysconfig.get_config_var('LIBDIR'))" to get /home/cz/work/python-3.6/bin/include/python3.6m /home/cz/work/python-3.6/bin/lib as include&lib location.

After applying this patch, I can finally install perspective in my environment.

timkpaine · 2022-04-01T13:16:05Z

@shinny-chengzhi you can run black on the setup.py. One other thing, it looks like this may relate to a bug in CMake so you should check if you're able to build without this PR but with a newer Cmake version

shinny-chengzhi · 2022-04-01T19:32:25Z

I tried building the latest CMake form source and the problem still preexist. Here is the log:

...
  running build_ext
  -- The C compiler identification is GNU 6.3.0
  -- The CXX compiler identification is GNU 6.3.0
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Check for working C compiler: /usr/bin/cc - skipped
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Check for working CXX compiler: /usr/bin/c++ - skipped
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- Found Boost: /usr/include (found version "1.67.0")
  -- Found Python: /home/cz/work/py36env/bin/python3.6 (found suitable exact version "3.6.5") found components: Interpreter Development Development.Module Development.Embed
  -- Found PythonInterp: /home/cz/work/py36env/bin/python3.6 (found suitable exact version "3.6.5")
  CMake Error at /home/cz/work/CMake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
    Could NOT find PythonLibs (missing: PYTHON_LIBRARIES PYTHON_INCLUDE_DIRS)
    (Required is exact version "3.6")
  Call Stack (most recent call first):
    /home/cz/work/CMake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
    /home/cz/work/CMake/Modules/FindPythonLibs.cmake:310 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
    CMakeLists.txt:377 (find_package)
  
  
  -- Configuring incomplete, errors occurred!
  See also "/tmp/pip-install-qhdxkse5/perspective-python/build/temp.linux-x86_64-3.6/CMakeFiles/CMakeOutput.log".
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-install-qhdxkse5/perspective-python/setup.py", line 259, in <module>
...

It's seem like this is a known bug: https://gitlab.kitware.com/cmake/cmake/-/issues/19525

timkpaine · 2022-04-03T19:53:38Z

python/perspective/setup.py

@@ -176,7 +183,7 @@ def build_extension_cmake(self, ext):
                    "-DCMAKE_TOOLCHAIN_FILE={}".format(vcpkg_toolchain_file)
                )

-            if sys.maxsize > 2 ** 32:
+            if sys.maxsize > 2**32:


needs spaces around operator for linting

finos-cla-bot · 2022-04-04T10:20:16Z

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@shinny-chengzhi).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

cc @maoo @TheJuanAndOnly99 @mcleo-d

shinny-chengzhi · 2022-04-04T10:20:35Z

Strange that when I run black it's constantly striping the space for me:

(py36env) cz@chengzhi:~$ black work/perspective/python/perspective/setup.py 
reformatted work/perspective/python/perspective/setup.py

All done! ✨ 🍰 ✨
1 file reformatted.

Is there any rules that need to be fed to black? Nevertheless, I have manually added these spaces back.

…ENABLE_PYTHON condition.

shinny-chengzhi · 2022-04-09T09:40:22Z

I've create a new one #1779 Since github didn't support changing source branch for PR.

shinny-chengzhi force-pushed the master branch from 7dca637 to 3289061 Compare March 31, 2022 10:46

timkpaine requested changes Mar 31, 2022

View reviewed changes

shinny-chengzhi force-pushed the master branch from 3289061 to 67403c5 Compare April 1, 2022 19:30

finos deleted a comment from finos-cla-bot bot Apr 2, 2022

timkpaine requested changes Apr 3, 2022

View reviewed changes

fix cmake build error when install under virtualenv

61557c6

shinny-chengzhi force-pushed the master branch from 67403c5 to 61557c6 Compare April 4, 2022 10:20

shinny-chengzhi requested a review from timkpaine April 7, 2022 08:32

shinny-yangyang added 5 commits April 8, 2022 10:43

Add "in recent" operator to datatime type filter.

d9e3c50

improve: std::binary_function has been removed in c++17.

f7300ea

improve: add a c++ update notify callback to pool.

6f674a6

refactor: enable access to origin config fields.

5faec47

change: some function is needed for c++ api, so move them out of PSP_…

b4ca406

…ENABLE_PYTHON condition.

finos deleted a comment from finos-cla-bot bot Apr 8, 2022

shinny-chengzhi mentioned this pull request Apr 9, 2022

fix cmake build error when install under virtualenv #1779

Merged

shinny-chengzhi closed this Apr 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix cmake build error when install under virtualenv #1777

fix cmake build error when install under virtualenv #1777

shinny-chengzhi commented Mar 31, 2022

finos-cla-bot bot commented Mar 31, 2022

timkpaine left a comment

shinny-chengzhi commented Apr 1, 2022

timkpaine commented Apr 1, 2022

shinny-chengzhi commented Apr 1, 2022

timkpaine Apr 3, 2022

finos-cla-bot bot commented Apr 4, 2022

shinny-chengzhi commented Apr 4, 2022

shinny-chengzhi commented Apr 9, 2022

fix cmake build error when install under virtualenv #1777

fix cmake build error when install under virtualenv #1777

Conversation

shinny-chengzhi commented Mar 31, 2022

finos-cla-bot bot commented Mar 31, 2022

timkpaine left a comment

Choose a reason for hiding this comment

shinny-chengzhi commented Apr 1, 2022

timkpaine commented Apr 1, 2022

shinny-chengzhi commented Apr 1, 2022

timkpaine Apr 3, 2022

Choose a reason for hiding this comment

finos-cla-bot bot commented Apr 4, 2022

shinny-chengzhi commented Apr 4, 2022

shinny-chengzhi commented Apr 9, 2022