Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade apache arrow to 6.0.2 #1636

Closed
wants to merge 3 commits into from
Closed

Upgrade apache arrow to 6.0.2 #1636

wants to merge 3 commits into from

Conversation

timkpaine
Copy link
Member

No description provided.

@timkpaine timkpaine added dependencies internal Internal refactoring and code quality improvement and removed cla-present labels Nov 28, 2021
@timkpaine timkpaine changed the title upgrade apache arrow to 6.0.2 Upgrade apache arrow to 6.0.2 Nov 29, 2021
@timkpaine
Copy link
Member Author

@texodus this is good to go but obviously just a maintenance PR, would be good to run the benchmarks to see if theres any material difference

@timkpaine timkpaine requested a review from texodus November 29, 2021 20:29
texodus
texodus approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

We should regression test the performance of this, but its not going to ultimately prevent us from upgrading, so I'm going to put this in a separate issue and merge this now to prevent it from bitrotting.

@texodus texodus mentioned this pull request Dec 20, 2021
Merged
@texodus
Copy link
Member

texodus commented Dec 20, 2021

Closing in favor of #1680

@texodus texodus closed this Dec 20, 2021
@timkpaine timkpaine deleted the arrow601 branch December 28, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @texodus