Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect semver for front end assets causing issues with voila #921

Closed
timkpaine opened this issue Feb 12, 2020 · 5 comments · Fixed by #923
Closed

Incorrect semver for front end assets causing issues with voila #921

timkpaine opened this issue Feb 12, 2020 · 5 comments · Fixed by #923
Assignees
@sc1f
Labels
bug Concrete, reproducible bugs Jupyter Python

Comments

@timkpaine
Copy link
Member

These versions are stale (they are not auto-incremented) which can cause issues with Voila loading the wrong version.

https://github.com/finos/perspective/blob/master/python/perspective/perspective/widget/widget.py#L144
@timkpaine timkpaine added bug Concrete, reproducible bugs Jupyter labels Feb 12, 2020
@texodus
Copy link
Member

texodus commented Feb 13, 2020

It also seems like the bumpversion script did not pick up 0.4.3 nor 0.4.2.post1.

@texodus texodus added the Python label Feb 13, 2020
@timkpaine
Copy link
Member Author

Since we have the package.json, can we just ship that and then read the version out of it?

@timkpaine
Copy link
Member Author

Then lerna can manage all the versioning and we can delete bumpversion

@sc1f
Copy link
Contributor

sc1f commented Feb 13, 2020

That sounds much nicer. I'll work it in.

@timkpaine
Copy link
Member Author

It's generally a bad idea to load up random files at runtime, but we would be loading up the _version.py file anyway

@sc1f sc1f linked a pull request Feb 13, 2020 that will close this issue
Fix for #921: unifies versioning between JS and Python libraries #923
Merged
texodus added a commit that referenced this issue Feb 20, 2020
@texodus
Merge pull request #923 from finos/fix-pyver
43af2a8 
Fix for #921: unifies versioning between JS and Python libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sc1f sc1f

Labels
bug Concrete, reproducible bugs Jupyter Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #921: unifies versioning between JS and Python libraries finos/perspective
3 participants
@texodus @timkpaine @sc1f