Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip in x/y line chart shows - and NaN #2575

Open
mhkeller opened this issue Mar 20, 2024 · 6 comments
Open

Tooltip in x/y line chart shows - and NaN #2575

mhkeller opened this issue Mar 20, 2024 · 6 comments
Labels
bug Concrete, reproducible bugs
Milestone
3.0

Comments

@mhkeller
Copy link

Bug Report

When creating a multi-series line chart, the values display correctly in the chart but y value shows up as NaN in a tooltip and x value is repeated and shows up as -.

Steps to Reproduce:

  1. Load this dummy data of student exams in different subjects and periods: https://gist.github.com/mhkeller/8831f579f814af2a7415e043457d4e56
  2. Select the X/Y line visualization
  3. Group by exam_month, split by exam_subject, set the x axis to exam_month (any) and the y axis to exam_score (avg)

Expected Result:

I'd expect to see the proper x and y-value in the tooltip.

Actual Result:

I see NaN in the tooltip for exam_score and exam_month shows up twice: once as the proper value and once as -.

Environment:

2.9.0 reproduced at https://perspective.finos.org/block/?example=file

Additional Context:

Screenshot 2024-03-20 at 13 38 34
@texodus texodus added the bug Concrete, reproducible bugs label Mar 21, 2024
@texodus
Copy link
Member

texodus commented Mar 21, 2024

Thanks for the report - I'm pretty sure this is the same behavior described in #2254, let me take a look and I will update

@mhkeller
Copy link
Author

Just wanted to check in on this and offer to take a look if you had some pointers on what code might be affecting this. I'm doing a data training next month and wanted to show this as an example.

@texodus
Copy link
Member

texodus commented Jun 25, 2024

@mhkeller I appreciate the enthusiasm but finding the issue is 90% of the work.

The master branch of this repo has already been updated for the 3.0 release and is not backwards compatible, so any fix for this will need to wait at least as long as this release, but I will make sure this fix is in by then.

@texodus texodus added this to the 3.0 milestone Jun 25, 2024
@mhkeller
Copy link
Author

Understood – and if I'm able to offer anything more than enthusiasm, I'll add a comment here. I'll start by getting a dev environment set up and see if there's any insight I can provide.

@wakek
Copy link
Contributor

wakek commented Sep 4, 2024

@mhkeller I appreciate the enthusiasm but finding the issue is 90% of the work.

The master branch of this repo has already been updated for the 3.0 release and is not backwards compatible, so any fix for this will need to wait at least as long as this release, but I will make sure this fix is in by then.

Hi @texodus,

I am able to reproduce this bug in version 3.0.3. I note that it has been added to the 3.0 milestone, however, I don’t see any in-progress draft PRs regarding this issue, so I’d like to contribute a fix for it.

Is it okay if I proceed with this?

@texodus
Copy link
Member

texodus commented Sep 4, 2024

Please read the CONTRIBUTING.md:

Don't ask for issues to be assigned to you if you're a first-time contributor.

If you can fix this without assistance, just do it and open a PR - if you cannot, don't ask.

@finos finos locked as spam and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@texodus @mhkeller @wakek