Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perspective-viewer-d3fc: Double group-by in Y-Bar not grouping bars correctly #2453

Open
mhkeller opened this issue Nov 27, 2023 · 2 comments
Open

perspective-viewer-d3fc: Double group-by in Y-Bar not grouping bars correctly #2453

mhkeller opened this issue Nov 27, 2023 · 2 comments
Labels
bug Concrete, reproducible bugs plugins

Comments

@mhkeller
Copy link

Bug Report

Steps to Reproduce:

  1. Load this dummy data of student exams in different subjects and periods: https://gist.github.com/mhkeller/8831f579f814af2a7415e043457d4e56
  2. Select the Y-bar visualization
  3. Group by period and exam_subject

Expected Result:

I would expect the bars within each period group to not have any white space between them.

Here's an example from the d3fc website that I expect it to look similar to.
Screenshot 2023-11-26 at 10 15 51 PM

Actual Result:

The bars are evenly spaced, making the chart harder to read since each of the groups is not visually separate.

Screenshot 2023-11-26 at 9 47 49 PM

Environment:

"@finos/perspective": "^2.7.0",
"@finos/perspective-viewer": "^2.7.0",
"@finos/perspective-viewer-d3fc": "^2.7.0",
"@finos/perspective-viewer-datagrid": "^2.7.0",

Chrome 119 and Firefox 120
@timkpaine timkpaine added bug Concrete, reproducible bugs plugins labels Feb 5, 2024
@mhkeller
Copy link
Author

@timkpaine If you have any suggestions on what might be causing this bug, I can try to take a look.

@mhkeller
Copy link
Author

Normally when creating charts like this, you have nested lists: the first group sets the range for a new scale. My feeling is that the data structure here is flat, hence why they are all appearing as siblings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs plugins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhkeller @timkpaine