Merge pull request #148 from redbearsam/fix/value_labels

sunburst - add labels, don't display if no crossValue is supplied
finos · Apr 2, 2019 · 9152dfb · 9152dfb
2 parents 9760eae + 5081a36
commit 9152dfb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/perspective-viewer-d3fc/src/js/charts/sunburst.js b/packages/perspective-viewer-d3fc/src/js/charts/sunburst.js
@@ -14,6 +14,8 @@ import {colorRangeLegend} from "../legend/colorRangeLegend";
 import {tooltip} from "../tooltip/tooltip";
 
 function sunburst(container, settings) {
+    if (settings.crossValues.length === 0) return;
+
     const sunburstData = treeData(settings);
     const {width: containerWidth, height: containerHeight} = container.node().getBoundingClientRect();
 

diff --git a/packages/perspective-viewer-d3fc/src/less/perspective-view.less b/packages/perspective-viewer-d3fc/src/less/perspective-view.less
@@ -31,7 +31,7 @@
   );
 }
 
-:host([view=d3_xy_scatter]), :host([view=d3_candlestick]), :host([view=d3_ohlc]) {
+:host([view=d3_xy_scatter]), :host([view=d3_candlestick]), :host([view=d3_ohlc]), :host([view=d3_sunburst]) {
  & #app {
    &.columns_horizontal #side_panel #inactive_columns {
      padding-top:28px
@@ -82,3 +82,15 @@
    }
  }
 }
+
+:host([view=d3_sunburst]) {
+ & #app #side_panel #active_columns perspective-row {
+   &:nth-child(1):before {
+     content:"Size"
+   }
+
+   &:nth-child(2):before {
+     content:"Color"
+   }
+ }
+}