Merge pull request #393 from jpmorganchase/webpack-example

Update Webpack example to webpack 4
finos · Jan 23, 2019 · 2a59ea7 · 2a59ea7
2 parents e01856f + 7afc019
commit 2a59ea7
Show file tree

Hide file tree

Showing 5 changed files with 1,533 additions and 59 deletions.
diff --git a/examples/webpack/in.js b/examples/webpack/in.js
@@ -8,7 +8,11 @@
  */
 
 const perspective = require("@jpmorganchase/perspective").default;
-require("@jpmorganchase/perspective-viewer");
 
-const table = perspective.worker().table([{x: 1}]);
-table.view().to_json(console.log);
+(async () => {
+    const worker = perspective.worker();
+    const table = worker.table([{x: 1, y: 2}, {x: 2, y: 2}]);
+    const view = await table.view();
+    const json = await view.to_json();
+    console.log(json);
+})();
diff --git a/examples/webpack/package.json b/examples/webpack/package.json
@@ -4,13 +4,20 @@
     "version": "0.2.12",
     "description": "An example of using the Perspective Webpack plugin to build a JS file with Webpack.",
     "scripts": {
-        "start": "node server.js",
+        "start": "webpack-dev-server --content-base ./ --hot",
         "webpack": "webpack --config webpack.config.js --color"
     },
     "keywords": [],
     "license": "Apache-2.0",
     "dependencies": {
         "@jpmorganchase/perspective": "^0.2.12",
-        "@jpmorganchase/perspective-viewer": "^0.2.12"
+        "@jpmorganchase/perspective-viewer": "^0.2.12",
+        "@jpmorganchase/perspective-viewer-highcharts": "^0.2.12",
+        "@jpmorganchase/perspective-viewer-hypergrid": "^0.2.12"
+    },
+    "devDependencies": {
+        "webpack": "^4.28.4",
+        "webpack-cli": "3.2.1",
+        "webpack-dev-server": "^3.1.14"
     }
 }
diff --git a/examples/webpack/webpack.config.js b/examples/webpack/webpack.config.js
@@ -11,6 +11,8 @@ const PerspectivePlugin = require("@jpmorganchase/perspective/webpack-plugin");
 const path = require("path");
 
 module.exports = {
+    context: __dirname,
+    mode: "development",
     entry: "./in.js",
     output: {
         filename: "out.js",

diff --git a/package.json b/package.json
@@ -6,7 +6,6 @@
     ],
     "devDependencies": {
         "@apache-arrow/es5-esm": "^0.3.1",
-        "babel-core": "^7.0.0-0",
         "babel-eslint": "^8.2.3",
         "babel-jest": "^23.6.0",
         "chart.js": "^2.7.1",