Merge pull request #2018 from finos/yew-20

Upgrade to Yew 0.20.0
finos · Nov 25, 2022 · 0ed75a9 · 0ed75a9
2 parents ef6df70 + 99158da
commit 0ed75a9
Show file tree

Hide file tree

Showing 23 changed files with 104 additions and 87 deletions.
diff --git a/packages/perspective-jupyterlab/test/results/results.json b/packages/perspective-jupyterlab/test/results/results.json
@@ -1,5 +1,5 @@
 {
-    "__GIT_COMMIT__": "c744efa438393bf46bf0d0801d9807fd86b64f51",
+    "__GIT_COMMIT__": "ef6df703f94bdda20d81b476d8725782904357db",
     "resize_Config_should_show_by_default": "f492628efc5ce5c9e1bab910cf2557c9",
     "resize_Resize_the_container_causes_the_widget_to_resize": "96a80143ba27bf42cc22d69c4ff1692a",
     "resize_group_by_traitlet_works": "f86409c2ccbdf3613a4aa20fc24cc543",

diff --git a/packages/perspective-viewer-d3fc/test/results/results.json b/packages/perspective-viewer-d3fc/test/results/results.json
@@ -1,5 +1,5 @@
 {
-    "__GIT_COMMIT__": "be50bcdfb1c1160ccc560af452db54446386ffcf",
+    "__GIT_COMMIT__": "ef6df703f94bdda20d81b476d8725782904357db",
     "area_shows_a_grid_without_any_settings_applied": "67bab9ea6654cc7cf7c7b096824e610a",
     "area_displays_visible_columns_": "9c195f0f7bf184a4cb9e727f1b37b301",
     "area_pivot_by_a_row": "fbae982b73c9cbf91be40a767cbbd3df",

diff --git a/packages/perspective-viewer-datagrid/test/results/results.json b/packages/perspective-viewer-datagrid/test/results/results.json
@@ -14,7 +14,7 @@
     "superstore_displays_visible_columns_": "09dd14f0e60da0e8749b7dd514e929f0",
     "superstore_resets_viewable_area_when_the_logical_size_expands_": "e9dd1d275f46f6a0857e0168835d0b38",
     "superstore_resets_viewable_area_when_the_physical_size_expands_": "e469597235cc032619bc095a76f9ad6f",
-    "__GIT_COMMIT__": "ab9e46542b4d70e46e676ed6f39c9ec4828e5715",
+    "__GIT_COMMIT__": "ef6df703f94bdda20d81b476d8725782904357db",
     "superstore_shows_a_grid_without_any_settings_applied": "192edc6b035af6432c5bd82d295987f1",
     "superstore_pivot_by_a_row": "709a4a6b40153d9bf013f90398ee568d",
     "superstore_pivot_by_two_rows": "23db46ccf9d8327ae992fe3b5f468b3b",
@@ -28,6 +28,6 @@
     "superstore_filters_filters_by_an_alpha_column": "4b9a40c2ffad050ff4cf059e22cb2b68",
     "superstore_filters_filters_with__in__comparator": "5882e2d2694519ba9880d0b2d5b19c44",
     "superstore_perspective-config-update_event_is_fired_when_column_style_is_changed": "3d03b2787f9b903050942052168f755a",
-    "superstore_Column_style_menu_opens_for_numeric_columns": "00994bacd3ef0dec04a14d12c1fa2d0c",
+    "superstore_Column_style_menu_opens_for_numeric_columns": "fc42b6bd729d72974f1f3c91dee18d8b",
     "superstore_Column_style_menu_opens_for_string_columns": "64ca2b3567212ac3b2a5184b7c033db5"
 }
diff --git a/packages/perspective-viewer-openlayers/test/results/results.json b/packages/perspective-viewer-openlayers/test/results/results.json
@@ -12,5 +12,5 @@
     "superstore_filters_filters_by_a_numeric_column": "80705a191c3675ed34d3058874f09a00",
     "superstore_filters_filters_by_an_alpha_column": "80705a191c3675ed34d3058874f09a00",
     "superstore_filters_filters_with__in__comparator": "80705a191c3675ed34d3058874f09a00",
-    "__GIT_COMMIT__": "be50bcdfb1c1160ccc560af452db54446386ffcf"
+    "__GIT_COMMIT__": "ef6df703f94bdda20d81b476d8725782904357db"
 }
diff --git a/packages/perspective-workspace/test/results/results.json b/packages/perspective-workspace/test/results/results.json
@@ -1,5 +1,5 @@
 {
-    "__GIT_COMMIT__": "0d5624d88d56d51c0d034ec07f665c4f06581044",
+    "__GIT_COMMIT__": "ef6df703f94bdda20d81b476d8725782904357db",
     "index_restore_workspace_with_detail_only": "d24f601369fbf86c853d4dd2894506e3",
     "index_Light_DOM_restore_workspace_with_detail_only": "e23bd42ed74c5efc2d067301b449027d",
     "index_Shadow_DOM_restore_workspace_with_detail_only": "aa44cdf6689ff93f68d4a4cffe292e09",

diff --git a/rust/perspective-viewer/Cargo.lock b/rust/perspective-viewer/Cargo.lock
diff --git a/rust/perspective-viewer/Cargo.toml b/rust/perspective-viewer/Cargo.toml
@@ -97,7 +97,7 @@ wasm-bindgen = { version = "=0.2.82", features = ["serde-serialize"] }
 wasm-bindgen-futures = "0.4.20"
 
 # https://github.com/yewstack/yew/issues/2154
-yew = { git = "https://github.com/yewstack/yew", rev = "7438cd3059d58d0922e4c15135961c8fab6f2552", features = ["csr"] }
+yew = { version = "0.20.0", features = ["csr"] }
 
 [dependencies.web-sys]
 version = "0.3.59"

diff --git a/rust/perspective-viewer/src/rust/components/column_selector/active_column.rs b/rust/perspective-viewer/src/rust/components/column_selector/active_column.rs
@@ -154,7 +154,7 @@ impl Component for ActiveColumn {
         }
     }
 
-    fn changed(&mut self, ctx: &Context<Self>) -> bool {
+    fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
         self.column_type = ctx.props().get_type();
         self.is_required = ctx.props().get_is_required();
         true

diff --git a/rust/perspective-viewer/src/rust/components/column_selector/aggregate_selector.rs b/rust/perspective-viewer/src/rust/components/column_selector/aggregate_selector.rs
@@ -65,7 +65,7 @@ impl Component for AggregateSelector {
         }
     }
 
-    fn changed(&mut self, ctx: &Context<Self>) -> bool {
+    fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
         self.aggregates = self.get_dropdown_aggregates(ctx);
         true
     }

diff --git a/rust/perspective-viewer/src/rust/components/config_selector.rs b/rust/perspective-viewer/src/rust/components/config_selector.rs
@@ -258,7 +258,7 @@ impl Component for ConfigSelector {
 
     /// Should not render on change, as this component only depends on service
     /// state.
-    fn changed(&mut self, _ctx: &Context<Self>) -> bool {
+    fn changed(&mut self, _ctx: &Context<Self>, _old: &Self::Properties) -> bool {
         false
     }
 

diff --git a/rust/perspective-viewer/src/rust/components/config_selector/filter_item.rs b/rust/perspective-viewer/src/rust/components/config_selector/filter_item.rs
@@ -313,7 +313,7 @@ impl Component for FilterItem {
         }
     }
 
-    fn changed(&mut self, ctx: &Context<Self>) -> bool {
+    fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
         if let Some(input) = ctx.props().get_filter_input() {
             self.input = input;
             true

diff --git a/rust/perspective-viewer/src/rust/components/containers/dragdrop_list.rs b/rust/perspective-viewer/src/rust/components/containers/dragdrop_list.rs
@@ -111,7 +111,7 @@ where
         }
     }
 
-    fn changed(&mut self, _ctx: &Context<Self>) -> bool {
+    fn changed(&mut self, _ctx: &Context<Self>, _old: &Self::Properties) -> bool {
         true
     }
 

diff --git a/rust/perspective-viewer/src/rust/components/containers/radio_list.rs b/rust/perspective-viewer/src/rust/components/containers/radio_list.rs
@@ -134,7 +134,7 @@ where
         false
     }
 
-    fn changed(&mut self, ctx: &Context<Self>) -> bool {
+    fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
         self.selected = ctx.props().selected.clone();
         true
     }

diff --git a/rust/perspective-viewer/src/rust/components/containers/scroll_panel.rs b/rust/perspective-viewer/src/rust/components/containers/scroll_panel.rs
@@ -232,7 +232,7 @@ where
     /// If the new total row height is different than last time this component
     /// was rendered, we need to double-render to read the container's
     /// potentially updated height.
-    fn changed(&mut self, ctx: &Context<Self>) -> bool {
+    fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
         let total_height = ctx.props().total_height(ctx);
         self.needs_rerender =
             self.needs_rerender || (self.total_height - total_height).abs() > 0.1f64;

diff --git a/rust/perspective-viewer/src/rust/components/containers/select.rs b/rust/perspective-viewer/src/rust/components/containers/select.rs
@@ -111,7 +111,7 @@ where
     }
 
     // The `<select>` has its own state not refelcted by `SelectProps`.
-    fn changed(&mut self, ctx: &Context<Self>) -> bool {
+    fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
         self.selected = ctx.props().selected.clone();
         true
     }

diff --git a/rust/perspective-viewer/src/rust/components/containers/split_panel.rs b/rust/perspective-viewer/src/rust/components/containers/split_panel.rs
@@ -300,7 +300,7 @@ impl Component for SplitPanel {
         }
     }
 
-    fn changed(&mut self, ctx: &Context<Self>) -> bool {
+    fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
         assert!(ctx.props().validate());
         let new_len = ctx.props().children.len();
         self.refs.resize(new_len, Default::default());
-Original file line number
+Diff line change
@@ Expand Up / @@ -65,7 +65,7 @@ impl Component for AggregateSelector { @@
             }
         }
-        fn changed(&mut self, ctx: &Context<Self>) -> bool {
+        fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
             self.aggregates = self.get_dropdown_aggregates(ctx);
             true
         }
@@ Expand Down @@