-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contributing companies #229
Open
ronaldssebalamu
wants to merge
22
commits into
finos:main
Choose a base branch
from
ronaldssebalamu:add-contributing-companies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add contributing companies #229
ronaldssebalamu
wants to merge
22
commits into
finos:main
from
ronaldssebalamu:add-contributing-companies
+6,280
−6,238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve merge and add panel back to morphir homepage
|
❌ Deploy Preview for angry-raman-7c44f6 failed.
|
@ronaldssebalamu this is awesome. Are you able to sign the CLA and fix the merge conflicts? |
Hey Damian,
Thanks for taking notice.
I had signed the CLA sometime back but on a different issue.
I am pretty sure, I will fix it.
I will let you know incase more questions arise.
Regards,
Ronald.
…On Fri, 9 Feb 2024, 5:32 pm Damian Reeves, ***@***.***> wrote:
@ronaldssebalamu <https://github.com/ronaldssebalamu> this is awesome.
Are you able to sign the CLA and fix the merge conflicts?
—
Reply to this email directly, view it on GitHub
<#229 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6IXM7H6QORVH5LUETWPHULYSYXRFAVCNFSM6AAAAABCN2NN6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWGAZTSNZTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks Ronald. When you've done the CLA, please add Snowflake too. |
stephengoldbaum
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves issue #179.
Additional screenshots