Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for json codec backend #137

Merged
merged 6 commits into from
Feb 9, 2023
Merged

Documentation for json codec backend #137

merged 6 commits into from
Feb 9, 2023

Conversation

klahnunya
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 1, 2023 •
edited
Loading

✅ Deploy Preview for angry-raman-7c44f6 canceled.

Name Link
🔨 Latest commit de0ad4e
🔍 Latest deploy log https://app.netlify.com/sites/angry-raman-7c44f6/deploys/63e4b8abf72f0d00078c9168

AttilaMihaly
AttilaMihaly requested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@AttilaMihaly AttilaMihaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a bit of work. Added specific comments.

docs/json-codec-backend/codec-docs.md Outdated Show resolved Hide resolved
docs/json-codec-backend/codec-docs.md Outdated Show resolved Hide resolved
docs/json-codec-backend/codec-docs.md Outdated Show resolved Hide resolved
docs/json-codec-backend/codec-docs.md Outdated Show resolved Hide resolved
docs/json-codec-backend/codec-docs.md Outdated Show resolved Hide resolved
docs/json-codec-backend/codec-docs.md Outdated Show resolved Hide resolved
AttilaMihaly
AttilaMihaly requested changes Feb 8, 2023
View reviewed changes
Copy link
Member

@AttilaMihaly AttilaMihaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I added a few more comments.

docs/json-codec-backend/codec-docs.md Outdated Show resolved Hide resolved
docs/json-codec-backend/codec-docs.md Outdated Show resolved Hide resolved
docs/json-codec-backend/codec-docs.md Outdated Show resolved Hide resolved
docs/json-codec-backend/codec-docs.md Outdated Show resolved Hide resolved
@AttilaMihaly AttilaMihaly merged commit 56c5605 into finos:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AttilaMihaly AttilaMihaly AttilaMihaly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klahnunya @AttilaMihaly