Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support secure interactions with private repositories 🔒 #806

Merged
merged 8 commits into from
Nov 20, 2024
Merged

feat: support secure interactions with private repositories 🔒 #806

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3e91582
chore: introduce isomorphic-git dependency (#552)
JamieSlome Nov 20, 2024
55ddf0c
fix: use isomorphic-git to support secure clone of repositories (#552)
JamieSlome Nov 20, 2024
cb29feb
chore: run npm audit fix
JamieSlome Nov 20, 2024
9d229d9
chore: include dummy auth header for git clone test
JamieSlome Nov 20, 2024
bcf3aaa
test: increase timeout for clone specific test function
JamieSlome Nov 20, 2024
a5fb6eb
Apply suggestions from code review
JamieSlome Nov 20, 2024
2f679df
chore: add Zlib license to dependency-review allow-licenses
JamieSlome Nov 20, 2024
793194f
Merge branch 'fix-private-to-private-contributions' of https://github…
JamieSlome Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use isomorphic-git to support secure clone of repositories (#552)
  • Loading branch information
@JamieSlome
JamieSlome committed Nov 20, 2024
commit 55ddf0cc02cfb880e899fe644bfdb4e2a80162a3
36 changes: 25 additions & 11 deletions src/proxy/processors/push-action/pullRemote.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
const spawnSync = require('child_process').spawnSync;
const Step = require('../../actions').Step;
const fs = require('fs');
const dir = './.remote';
const git = require('isomorphic-git');
const http = require('isomorphic-git/http/node');

JamieSlome marked this conversation as resolved.
Show resolved Hide resolved
const exec = async (req, action) => {
const step = new Step('pullRemote');
Expand All @@ -19,20 +20,33 @@ const exec = async (req, action) => {
fs.mkdirSync(action.proxyGitPath, '0755', true);
}

const cmd = `git clone ${action.url} --bare`;

const cmd = `git clone ${action.url}`;
step.log(`Exectuting ${cmd}`);

const response = spawnSync('git', ['clone', action.url, '--bare', '--progress'], {
cwd: action.proxyGitPath,
encoding: 'utf-8',
});

const cloneOutput = response?.stderr;
step.log(cloneOutput);
const authHeader = req.headers?.authorization;
const [username, password] = Buffer.from(authHeader.split(' ')[1], 'base64')
.toString()
.split(':');

await git
.clone({
fs,
http,
url: action.url,
JamieSlome marked this conversation as resolved.
Show resolved Hide resolved
onAuth: () => {
return {
username: username,
password: password,
};
},
dir: `${action.proxyGitPath}/${action.repoName}`,
JamieSlome marked this conversation as resolved.
Show resolved Hide resolved
})
.then(() => {
console.log('Clone Success: ', action.url);
});

JamieSlome marked this conversation as resolved.
Show resolved Hide resolved
step.log(`Completed ${cmd}`);
step.setContent(cloneOutput);
step.setContent(`Completed ${cmd}`);
} catch (e) {
JamieSlome marked this conversation as resolved.
Show resolved Hide resolved
step.setError(e.toString('utf-8'));
throw e;
Expand Down
Loading