Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git Proxy does not support GitLab repos #511

Open
msagi opened this issue Apr 1, 2024 · 6 comments · May be fixed by #545
Open

Git Proxy does not support GitLab repos #511

msagi opened this issue Apr 1, 2024 · 6 comments · May be fixed by #545
Assignees
@abinash2512
Labels
bug Something isn't working

Comments

@msagi
Copy link
Contributor

msagi commented Apr 1, 2024

Describe the bug
Failed to do git push with a GitLab repo.

To Reproduce
Steps to reproduce the behavior:

  1. unzip gitlab-issue.tar.gz
  2. start git-proxy with the config file (proxy.config.json) from the .tar.gz file
  3. execute git-proxy-issue-repro.sh
  4. compare the *.run.log files with your run logs
  5. compare .data/db files with your data

Expected behavior
git push is successful (with GitLab repo)

Screenshots
n/a

Desktop (please complete the following information):

  • OS: macOS 14.4.1 (23E224)
  • Git: git version 2.39.3 (Apple Git-146)
  • Browser n/a
  • Version n/a

Additional context
src/proxy/actions/Action.js: 56
this.url = https://github.com/${repo};

this might be the cause of the issue: GitHub is hardcoded baseURL into the action
@JamieSlome JamieSlome added bug Something isn't working good first issue Good for newcomers labels Apr 2, 2024
@abinash2512
Copy link

Happy to pick this one up while waiting for #414 to be approved license-wise

@JamieSlome
Copy link
Member

@abinash2512 - awesome, fire away! 🔥

@msagi
Copy link
Contributor Author

msagi commented Apr 13, 2024

@JamieSlome @abinash2512 - I believe, we lose the git server domain name with git remote set-url origin <git-proxy-host:port>/repo-name.git. Unless we match incoming push requests with the list of authorised repos in proxy.config.json , we won't be able to tell the domain name. This way, GitProxy becomes able to support multiple Git servers but the project/repo-name must stay unique across the ecosystem, aka GitProxy won't be able to support https://gitlab.com/msagi/test-repo.git and https://github.com/msagi/test-repo.git at the same time.

@msagi
Copy link
Contributor Author

msagi commented Apr 29, 2024

Hi @abinash2512 , how are you doing with this issue? Do you need help? I’m happy to chip in 🚀🚀🚀

@msagi msagi linked a pull request May 4, 2024 that will close this issue
Open
@msagi
Copy link
Contributor Author

msagi commented May 6, 2024

Hi @abinash2512 @JamieSlome , I've spent some time with this issue. Perhaps this is a bit more complex than a good-first-issue. Can you take a look at the PR I made, and give me any feedback or comments?

@JamieSlome
Copy link
Member

Removing good first issue as it appears a little more extensive than initially thought 👍

@JamieSlome JamieSlome removed the good first issue Good for newcomers label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abinash2512 abinash2512

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add gitlab support msagi/git-proxy
3 participants
@msagi @JamieSlome @abinash2512