Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Upgrade Translator Project #717

Open
jpgough-ms opened this issue Dec 31, 2024 · 8 comments
Open

Remove/Upgrade Translator Project #717

jpgough-ms opened this issue Dec 31, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@jpgough-ms
Copy link
Member

jpgough-ms commented Dec 31, 2024

Bug Report

Steps to Reproduce:

Dependencies and builds are stale in the translator project.

Expected Result:

Builds are failing due to out of date dependencies

Actual Result:

Build should pass

@Budlee and @matthewgardner should we remove or upgrade this component?

@jpgough-ms jpgough-ms added the bug Something isn't working label Dec 31, 2024
jpgough-ms added a commit to jpgough-ms/architecture-as-code that referenced this issue Dec 31, 2024
@Budlee
Copy link
Member

Budlee commented Jan 1, 2025

Happy to fix the upgrades, I can do that in the next few days.

Originally we had this project to have a way to translate CALM to C4 in order to have a visualisation. I see this functionality moving into other parts of the project, specifically around the vscode extension. I think that a shared TypeScript library where the functionality for visualisation can as a better option

@matthewgardner what do you want to do with the K8s resource generation. I do see it as useful functionality still.

@jpgough
Copy link

jpgough commented Jan 1, 2025

@Budlee we merged a PR yesterday #720 - there’s one more library with an issue, but we might need spring parent bom updates to apply.

@willosborne had a prototype of k8s generation working for a demo last year. @rocketstack-matt perhaps we should demo/discuss this in the next office hours?

@rocketstack-matt
Copy link
Member

Agreed . . . I have been in favour of moving into the CLI, which would necessitate a re-write, although I do think now we have CALM Hub there is a supportable path forward for the Java version.

@Budlee
Copy link
Member

Budlee commented Jan 6, 2025

@jpgough , missed your reply. I'll take a look at the dependency.

@rocketstack-matt, shall we make an issue spike out moving the functionality to the CLI? I remember I had a look at Typescript integration with C4 Structurizer and it was not there when I first created it. Maybe this has changed. Else we offer the functionality as part of the CALMHub?

@Budlee
Copy link
Member

Budlee commented Jan 6, 2025

@jpgough I see what you mean that there needs to be an upgrade from spring, the fix release date is set for the 25th. (spring-projects/spring-boot#43568)

We can wait for that or just manually override the dependency, any preferance

@rocketstack-matt
Copy link
Member

If it's not a big deal for us to set the override I would, if it is a problem, but we're comfortable we can't be exploited (per the comment on your link) then I would set the CVE suppression with a link to that comment in the PR until the upgrade is released.

@jpgough-ms
Copy link
Member Author

jpgough-ms commented Jan 6, 2025

@rocketstack-matt you've already patched the logging CVE (I think), we should revert that when we move to the next version of Spring Boot. There is the bigger question of removal still.

@rocketstack-matt
Copy link
Member

Sorry, you're right - my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants