-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a control statement field to be in line with a policy #687
Comments
I'm personally of the view that yourself and @aldwin-ms are our security experts. We can discuss on office hours, but I think if this is your proposal we should adopt it, certainly this is not yet in active use so we're not going to break anyone. A couple of questions I would have though are:
|
Tag: @LeighFinegold, @rocketstack-matt, @dc-ms From the #745, statement would be in a more specific type than control requirement? |
I would say no, as the statement is a hard definition, I'd expect it to contain this MUST do X. Like in https://datatracker.ietf.org/doc/html/rfc2119. However, the description would be more of an internal description or relevant information.
|
@jpgough-ms I do think the next question on this is going to be about evaluation of control-statements, in the example you created there was a rego statement. Additionally you could argue that to enforce any controls that you want to put in a policy do you just re-use Spectral or should it be another tool like OPA? |
At this point in time, nothing will evaluate control statements. What is a Control Requirement?
What is a Control Configuration?
But what? How does that make sense?
Given all of the above, the lack of detail means it's not really feasible for us to build generic tooling around controls at this time. We will be able to pull them into our documentation generation and use them to enable traceability / capture evidence / etc. but for controls where we want to provide systematic enforcement, I believe they would need to either be user specific (the organisation specifying their controls would need to build their bespoke tools to understand their specifications). Overtime, if we have consensus in the community that there are common control requirements in specific domains with more strongly typing, then we could start talking about central tooling to support that domain. |
Feature Request
Currently we have the concept of a control_requirement that consists of
control-id
,name
anddescription
.When we think of controls these are usually backed by a control statement, a control statement being the reason for a control in the first place.
Lets take the OAuth2 spec there are various control statements in the RFC e.g.
the authorization server MUST NOT rely on public client authentication for the purpose of identifying the client.
The authorization server MUST require the use of TLS as described in Section 1.6 when sending requests using password authentication
The name of these are the description are different.
e.g.
Potential Solutions:
statement
as a mandatory field in control_requirement, if we believe that all control requirements have a control statement then it should be placed hereIt would be great to hear what others think on this subject
TAG: @aldwins-ms @jpgough-ms @yt-ms @rocketstack-matt
The text was updated successfully, but these errors were encountered: