Fix memhog uses the wrong policy but still works properly

`memhog 1G memb` can work, it will cause misunderstanding. When the parameter is incorrect, Now it directly use the last assignment of p, "default".After the fixed, the usage will be displayed in this case.
filbranden · Aug 25, 2022 · 1de4ad7 · 1de4ad7
1 parent 4b4e31d
commit 1de4ad7
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/util.c b/util.c
@@ -111,16 +111,20 @@ int parse_policy(char *name, char *arg)
 {
 	int k;
 	struct policy *p = NULL;
+	int found = 0;
+
 	if (!name)
 		return MPOL_DEFAULT;
 
 	while (*name == '-') name++;
 	for (k = 0; policies[k].name; k++) {
 		p = &policies[k];
-		if (!strcmp(p->name, name))
+		if (!strcmp(p->name, name)) {
+			found = 1;
 			break;
+		}
 	}
-	if (!p || !p->name || (!arg && !p->noarg))
+	if (!found || !p || !p->name || (!arg && !p->noarg))
 		return MPOL_MAX;
     return p->policy;
 }