Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux. sDNA Prepare. False negative in regression test. Network links appear in a different order on Linux to Windows (the expected reference result). #83

Open
JamesParrott opened this issue Jun 27, 2024 · 1 comment
Open

Linux. sDNA Prepare. False negative in regression test. Network links appear in a different order on Linux to Windows (the expected reference result). #83

JamesParrott opened this issue Jun 27, 2024 · 1 comment

Comments

@JamesParrott
Copy link
Collaborator

TODO: Add another option to sDNA\sdna_vs2008\tests\pytest\test_gathering_windows_command_line_tests.py to store all the links in
a in a non-ordered data structure (e.g. a set), and test that for equality instead of requiring line by line (almost) equality.

FAILED test_gathering_windows_command_line_tests.py::test_diff_[correctout_prep.txt] - AssertionError: Error on line num i: 334.  This line (and up to the 9 previous ones):
  Expected: "[('ID', 46), ('sametext', '1'), ('difftext', '46'), ('start_gs', 0.0), ('end_gs', 0.0), ('weight', 1.0), ('cost', 1.0), ('island', 0.0)]  (((18,0,0),(18,20,0)))"
  "[('ID', 47), ('sametext', '1'), ('difftext', '47'), ('start_gs', 0.0), ('end_gs', 0.0), ('weight', 1.0), ('cost', 1.0), ('island', 0.0)]  (((0,18,0),(20,18,0)))"
  "[('ID', 48), ('sametext', '1'), ('difftext', '48'), ('start_gs', 0.0), ('end_gs', 0.0), ('weight', 1.0), ('cost', 1.0), ('island', 0.0)]  (((19,0,0),(19,20,0)))"
  "[('ID', 49), ('sametext', '1'), ('difftext', '49'), ('start_gs', 0.0), ('end_gs', 0.0), ('weight', 1.0), ('cost', 1.0), ('island', 0.0)]  (((0,19,0),(20,19,0)))"
  'Using xytolerance=0, ztolerance=0'
  'result'
  'net - POLYLINEZ (799 items)'
  "[('ID', 'ID', 'INT')]"
  "[('ID', -1)]  (((1,0,0),(0,0,0),(0,1,0)))"
  "[('ID', 0)]  (((0,8,0),(1,8,0)))", 
  
   Actual: "[('ID', 46), ('sametext', '1'), ('difftext', '46'), ('start_gs', 0.0), ('end_gs', 0.0), ('weight', 1.0), ('cost', 1.0), ('island', 0.0)]  (((18,0,0),(18,20,0)))"
  "[('ID', 47), ('sametext', '1'), ('difftext', '47'), ('start_gs', 0.0), ('end_gs', 0.0), ('weight', 1.0), ('cost', 1.0), ('island', 0.0)]  (((0,18,0),(20,18,0)))"
  "[('ID', 48), ('sametext', '1'), ('difftext', '48'), ('start_gs', 0.0), ('end_gs', 0.0), ('weight', 1.0), ('cost', 1.0), ('island', 0.0)]  (((19,0,0),(19,20,0)))"
  "[('ID', 49), ('sametext', '1'), ('difftext', '49'), ('start_gs', 0.0), ('end_gs', 0.0), ('weight', 1.0), ('cost', 1.0), ('island', 0.0)]  (((0,19,0),(20,19,0)))"
  'Using xytolerance=0, ztolerance=0'
  'result'
  'net - POLYLINEZ (799 items)'
  "[('ID', 'ID', 'INT')]"
  "[('ID', -1)]  (((1,0,0),(0,0,0),(0,1,0)))"
  "[('ID', 0)]  (((0,10,0),(1,10,0)))"
@JamesParrott JamesParrott changed the title Linux. sDNA Prepare. False negative in regression test. Network links appear in a different order on Linux to Windows (expected). Linux. sDNA Prepare. False negative in regression test. Network links appear in a different order on Linux to Windows (the expected reference result). Jun 27, 2024
@JamesParrott
Copy link
Collaborator Author

Marked as xfail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesParrott