Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression when compiled using Zig/Clang. test_diff_[correctout_prep.txt] #65

Open
JamesParrott opened this issue Jun 10, 2024 · 1 comment
Open

Regression when compiled using Zig/Clang. test_diff_[correctout_prep.txt] #65

JamesParrott opened this issue Jun 10, 2024 · 1 comment

Comments

@JamesParrott
Copy link
Collaborator

JamesParrott commented Jun 10, 2024 •
edited
Loading

This one could be the same link subsystems being outputted in different orders again, or a different link (with different id) being selected from that subsystem

E               AssertionError: Error on line num i: 20.  This line (and up to the 9 previous ones):
E                 Expected: 'Reading features from prep_crash_shapefile\\shapefilepreparecrash'
E                 '  sDNA is running in 64-bit mode'
E                 '  Fixing near miss connections'
E                 '  Fixing duplicate links'
E                 '  Checking for isolated systems'
E                 '  Largest system contains 21523 links'
E                 '7-link subsystem contains link with id = 8285'
E                 '6-link subsystem contains link with id = 9654'
E                 '4-link subsystem contains link with id = 8028'
E                 '3-link subsystem contains link with id = 9920',
E
E                  Actual: 'Reading features from prep_crash_shapefile\\shapefilepreparecrash'
E                 '  sDNA is running in 64-bit mode'
E                 '  Fixing near miss connections'
E                 '  Fixing duplicate links'
E                 '  Checking for isolated systems'
E                 '  Largest system contains 21523 links'
E                 '7-link subsystem contains link with id = 8285'
E                 '6-link subsystem contains link with id = 9654'
E                 '4-link subsystem contains link with id = 8028'
E                 '3-link subsystem contains link with id = 7162'

The good news is the other 5 tests pass:

======================================================= PASSES ========================================================
____________________________________________ test_diff_[correctout3d.txt] _____________________________________________
------------------------------------------------ Captured stdout call -------------------------------------------------
Passed! Num of equal expected & actual lines": 102. (Num lines skipped: 0 exc debug etc.)
_________________________________________ test_diff_[correctout_partial.txt] __________________________________________
------------------------------------------------ Captured stdout call -------------------------------------------------
Passed! Num of equal expected & actual lines": 1828. (Num lines skipped: 0 exc debug etc.)
__________________________________________ test_diff_[correctout_learn.txt] ___________________________________________
------------------------------------------------ Captured stdout call -------------------------------------------------
Passed! Num of equal expected & actual lines": 73. (Num lines skipped: 0 exc debug etc.)
__________________________________________ test_diff_[correctout_table.txt] ___________________________________________
------------------------------------------------ Captured stdout call -------------------------------------------------
Passed! Num of equal expected & actual lines": 121. (Num lines skipped: 1 exc debug etc.)
____________________________________________ test_diff_[correctout_od.txt] ____________________________________________
------------------------------------------------ Captured stdout call -------------------------------------------------
Passed! Num of equal expected & actual lines": 396. (Num lines skipped: 0 exc debug etc.)
=============================================== short test summary info ===============================================
PASSED test_gathering_windows_command_line_tests.py::test_diff_[correctout3d.txt]
PASSED test_gathering_windows_command_line_tests.py::test_diff_[correctout_partial.txt]
PASSED test_gathering_windows_command_line_tests.py::test_diff_[correctout_learn.txt]
PASSED test_gathering_windows_command_line_tests.py::test_diff_[correctout_table.txt]
PASSED test_gathering_windows_command_line_tests.py::test_diff_[correctout_od.txt]
@JamesParrott
Copy link
Collaborator Author

On Linux, the same issue occurs, but with a different link ID:

FAILED test_gathering_windows_command_line_tests.py::test_diff_[correctout_prep.txt] - AssertionError: Error on line num i: 19.  This line (and up to the 9 previous ones):
  Expected: 'Reading features from prep_crash_shapefile/shapefilepreparecrash'
  'Reading features from prep_crash_shapefile/shapefilepreparecrash'
  '  sDNA is running in 64-bit mode'
  '  Fixing near miss connections'
  '  Fixing duplicate links'
  '  Checking for isolated systems'
  '  Largest system contains 21523 links'
  '7-link subsystem contains link with id = 8285'
  '6-link subsystem contains link with id = 9654'
  '4-link subsystem contains link with id = 8028', 
  
   Actual: 'Reading features from prep_crash_shapefile/shapefilepreparecrash'
  'Reading features from prep_crash_shapefile/shapefilepreparecrash'
  '  sDNA is running in 64-bit mode'
  '  Fixing near miss connections'
  '  Fixing duplicate links'
  '  Checking for isolated systems'
  '  Largest system contains 21523 links'
  '7-link subsystem contains link with id = 8285'
  '6-link subsystem contains link with id = 9654'
  '4-link subsystem contains link with id = 12290'

E.g. https://github.com/fiftysevendegreesofrad/sdna_plus/actions/runs/9584485547/job/26428551575

@JamesParrott JamesParrott mentioned this issue Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesParrott