Skip to content

Commit

Permalink
fixup! tests: add server.Stop() and server.GracefulStop testcases
Browse files Browse the repository at this point in the history
  • Loading branch information
fho committed Oct 27, 2023
1 parent c03201f commit e7b4971
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/gracefulstop_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ func (s) TestGracefulStopClosesConnAfterLastStream(t *testing.T) {

func (s) TestGracefulStopBlocksUntilGRPCConnectionsTerminate(t *testing.T) {
// This tests ensures that GracefulStop() blocks until all ongoing
// client grpc-calls finished.
// client GRPC calls finished.
unblockGRPCCall := make(chan struct{})
grpcCallExecuting := make(chan struct{})
ss := &stubserver.StubServer{
Expand Down Expand Up @@ -269,8 +269,8 @@ func (s) TestStopAbortsBlockingGRPCCall(t *testing.T) {
// This tests ensures that when Stop() is called while an ongoing grpc
// call is blocking that:
// - Stop() returns
// - and grpc-call on the client side fails with an connection closed
// error
// - and the GRPC call on the client side fails with an connection
// closed error
unblockGRPCCall := make(chan struct{})
grpcCallExecuting := make(chan struct{})
ss := &stubserver.StubServer{
Expand Down

0 comments on commit e7b4971

Please sign in to comment.