Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parse_input kwarg to Transform #696

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Add parse_input kwarg to Transform #696

merged 1 commit into from
Oct 19, 2021

Conversation

fepegar
Copy link
Owner

@fepegar fepegar commented Oct 18, 2021

Fixes #695.

Description

  1. Added the parse_input kwarg to Transform
  2. Set this to False in Compose and OneOf
  3. This should have happened in Add Resize transform #642, and definitely not here, but added Resize to the list of transforms that don't need to be in the transforms history

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed
  • If the PR is ready and there are multiple commits, I have squashed them and force-pushed

@fepegar fepegar merged commit 8daf131 into master Oct 19, 2021
@fepegar fepegar deleted the 695-add-parse-input branch October 19, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compose should not change the input type
1 participant