Make lightning gateway optional #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mint-clint-cli gets command to generate invoices - Gateway plugin automatically generates gateway.json if it isn't there. Removed gw_configgen bin script. - Add route hint to invoices we generate - Gateway uses channels to concurrency between webserver, plugin and background fetching - Had to add more features to tracing dependency for the gateway crate because Core Lightning communicates to plugins via stdin/ stdout. Logging is routed via JSON-RPC. These feature flags helped make that work. -
- Lightning gateway no longer generates `client.json`. `configgen` does that now. - `run_webserver` reads gateway port from config, doesn't hard-code - Gateway API endpoint to fetch node pubkey and ecash pubkey
justinmoon
commented
Jul 6, 2022
| @@ -46,5 +46,5 @@ impl<CO> OwnedClientContext<CO> { | |||
| #[derive(Debug, Serialize, Deserialize)] | |||
| pub struct ClientAndGatewayConfig { | |||
| pub client: ClientConfig, | |||
| pub gateway: LightningGateway, | |||
| pub gateway: Option<LightningGateway>, | |||
There was a problem hiding this comment.
This should be a Vec
elsirion
reviewed
Jul 8, 2022
| # Send bitcoin to gateway lightning address | ||
| bitcoin-cli -regtest -rpcuser=bitcoin -rpcpassword=bitcoin sendtoaddress <LN_ADDRESS> <AMOUNT> | ||
| # Send bitcoin to gateway lightning address, and mine a block to confirm it | ||
| bitcoin-cli -regtest -rpcuser=bitcoin -rpcpassword=bitcoin sendtoaddress <LN_ADDRESS> 1.0 |
There was a problem hiding this comment.
Should have large enough denominations for this to not take days (e.g. if the server had to issue 100'000 tokens)
This was referenced Jul 10, 2022
|
Closing in favor of #269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #174. Just look at 2nd commit.
Our README on master right now claims that the gateway is optional, but our code doesn't. Instead, we just generate a random node pubkey! But this isn't a problem because it would only be used in an invoice and we haven't done that, yet.
So this PR attempt to make the gateway optional. It also stops having the gateway code generate
client.jsonand instead adds a new command toconfiggento do this. Along the way I added a/infoendpoint to the gateway HTTP server so you can look up gateway public keys.