allow client-only architecture #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please create a shim layer and make it a compile time switch. |
eagleoflqj
force-pushed
the
serverless
branch
from
26f6c97 to
d463270
Compare
eagleoflqj
changed the title
eagleoflqj
force-pushed
the
serverless
branch
from
864d499 to
b585a9c
Compare
wengxt
reviewed
Dec 24, 2024
src/unix/fcitx5/BUILD.bazel
Outdated
| "@fcitx5", | ||
| ], | ||
| ) | ||
|
|
||
| mozc_cc_library( | ||
| name = "mozc_client_impl", |
There was a problem hiding this comment.
- create mozc_client_interface target, things like mozc_engine can depend on it.
- Create two mozc_client_impl target one with server, one without.
- use select() on target, not on source files or deps, if possible.
wengxt
reviewed
Dec 24, 2024
src/unix/fcitx5/BUILD.bazel
Outdated
| "//client", | ||
| "//protocol:commands_cc_proto", | ||
| ], | ||
| config_setting( |
There was a problem hiding this comment.
You can see how it defines a flag and have a sane default value. (Hint: string_flag & "//conditions:default" ).
Also, "server" as a name is too generic. Better to define a name with "fcitx" in it so it's unique to fcitx (if you use string_flag you will get it for free, since flag is now --//unix/fcitx5:...
wengxt
reviewed
Dec 24, 2024
src/unix/fcitx5/mozc_client.cc
Outdated
| return false; | ||
| } | ||
|
|
||
| #if defined(_WIN32) || defined(__linux__) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android, iOS and Web cannot use the C-S architecture as-is. The core part of server is SessionHandler. Created a static global variable so server is not needed.
Created
MozcClientInterfaceto allow both architectures.MozcClientis a simplified version ofmozc::client::Client, which keeps all APIs used by fcitx and discards those not used.MozcClientHolderbecomes a proxy ofmozc::client::Client.--define server=1to keep existing C-S arch and--define server=0for simplified arch.Note: only Linux C-S should still be preferred because mozc_tool also talks to mozc_server. Only other platforms there is no mozc_tool yet so this is not a concern compared to not having fcitx5-mozc running at all.