Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature check #2

Closed
Aliance opened this issue Mar 31, 2016 · 5 comments
Closed

Signature check #2

Aliance opened this issue Mar 31, 2016 · 5 comments

Comments

@Aliance
Copy link

Aliance commented Mar 31, 2016

Why there are no X-Hub-Signature check in this examples?
@adamgross42
Copy link
Contributor

The initial version was just a basic implementation, and checking the X-Hub-Signature is not required. Definitely a good idea to add this in though, let's leave this issue open to remember. Pull requests are welcome :)

@Aliance
Copy link
Author

Aliance commented Apr 1, 2016

There are 2 examples now: coffee and node, am I right? I can add a PHP Example, may I?

@adamgross42
Copy link
Contributor

Correct, those are the two examples right now, aligned with hosting services for executing them. You're welcome to add a PHP example as well.

@adamgross42
Copy link
Contributor

Another thought about the X-Hub-Signature value - it would require the app secret be available to the server, which would be an additional step beyond basic configuration.

@adamgross42 adamgross42 mentioned this issue Jun 9, 2016
Merged
@adamgross42
Copy link
Contributor

Closed by #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamgross42 @Aliance