Remove two of todos in code: test and one obsolete one

fbs · Dec 26, 2023 · 0f3d5b0 · 0f3d5b0
1 parent 77fb977
commit 0f3d5b0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/collectors/collector_manager.go b/collectors/collector_manager.go
@@ -48,7 +48,7 @@ func NewCollectorManager(servers []*config.LogstashServer) *CollectorManager {
 func getCollectors(clients []logstashclient.Client) map[string]Collector {
 	collectors := make(map[string]Collector)
 	collectors["nodeinfo"] = nodeinfo.NewNodeinfoCollector(clients)
-	collectors["nodestats"] = nodestats.NewNodestatsCollector(clients) // TODO: support multiple clients
+	collectors["nodestats"] = nodestats.NewNodestatsCollector(clients)
 	return collectors
 }
 

diff --git a/collectors/nodestats/nodestats_collector_test.go b/collectors/nodestats/nodestats_collector_test.go
@@ -138,8 +138,18 @@ func TestCollectNotNil(t *testing.T) {
 			t.Errorf("failed to extract fqName from metric %s", foundMetricDesc)
 		}
 
-		// todo: check if exists
-		foundMetrics = append(foundMetrics, foundMetricFqName)
+		// todo: optimize this
+		found := false
+		for _, foundMetric := range foundMetrics {
+			if foundMetric == foundMetricFqName {
+				found = true
+				break
+			}
+		}
+
+		if !found {
+			foundMetrics = append(foundMetrics, foundMetricFqName)
+		}
 	}
 
 	for _, expectedMetric := range expectedBaseMetrics {