Fix nident error in configmap setting, improve Helm testing workflow (k…

…uskoman#245) * Fix nident error in configmap setting * Add log printing to helm integration workflow * Add templating step to helm workflow * Change Helm chart deploy timeout to 10m * Fix configmap indentation one more time
fbs · Feb 2, 2024 · 0de44c1 · 0de44c1
1 parent 9612288
commit 0de44c1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.github/workflows/go-application.yml b/.github/workflows/go-application.yml
@@ -378,9 +378,17 @@ jobs:
       - name: Export Docker image to Kind cluster
         run: kind load docker-image logstash-exporter:latest --name kind-chart-testing
 
+      - name: Template Helm chart
+        working-directory: .helm/logstash-integration-test-chart
+        run: helm template .
+
       - name: Install Helm chart
         working-directory: .helm/logstash-integration-test-chart
-        run: helm install --atomic --wait --timeout 15m --debug logstash-integration-test-chart .
+        run: helm install --wait --timeout 10m --debug logstash-integration-test-chart .
+
+      - name: Print exporter logs
+        run: kubectl logs -n default -l app=logstash-exporter
+        if: failure()
 
   create-release:
     name: Create GitHub release

diff --git a/chart/templates/configmap.yaml b/chart/templates/configmap.yaml
@@ -14,7 +14,7 @@ data:
       servers:
         {{ range .Values.logstash.urls -}}
         - url: {{ . | quote }}
-        {{- end }}
+        {{ end }}
     server:
       host: {{ .Values.logstash.server.host | quote }}
       port: {{ .Values.logstash.server.port }}

diff --git a/chart/values.yaml b/chart/values.yaml
@@ -31,7 +31,7 @@ customConfig:
   ##
   config: |
     logstash:
-      urls:
+      servers:
         - "http://logstash:9600"
 
 ## @section Image settings