Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ Deprecate shell_complete and continue to use autocompletion for CLI parameters #974

Merged
merged 12 commits into from
Dec 4, 2024
Merged

🗑️ Deprecate shell_complete and continue to use autocompletion for CLI parameters #974

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
698d85e
fix typos
svlandeg Sep 4, 2024
f47750f
fix typo
svlandeg Sep 4, 2024
1173192
update warning to deprecate shell_complete
svlandeg Sep 5, 2024
1975fce
add notes in the source code that shell_complete is not supported and…
svlandeg Sep 5, 2024
cfbeb3d
add note in the documentation about comparison to Click functionality
svlandeg Sep 5, 2024
749cade
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Sep 5, 2024
286b94e
fix if conditions
svlandeg Sep 5, 2024
ca4ca2c
remove test with shell_complete in Option
svlandeg Sep 5, 2024
2261391
rephrase slightly
svlandeg Sep 5, 2024
e17a0f5
fix
svlandeg Sep 5, 2024
37cbc85
Merge branch 'master' into feat/autocompletion
tiangolo Dec 4, 2024
5d13465
💡 Add extra TODO comments to remind us in the future to remove shell_…
tiangolo Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@svlandeg
svlandeg committed Sep 5, 2024
commit e17a0f56bd05effcaaafcec6263fddd84d3a4098
2 changes: 1 addition & 1 deletion docs/tutorial/options-autocompletion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ It doesn't matter how you name them, in which order, or which ones of the 3 opti

Note that Click 7 had a similar [`autocompletion` function](https://click.palletsprojects.com/en/7.x/bashcomplete/), but it worked slightly differently.

It required the callback function to take exactly the 3 keyword arguments `ctx`, `args` and `incomplete` in that exact order, instead of matching them dynamically based on types, as Typer does.
It required the callback function to take exactly the 3 arguments `ctx`, `args` and `incomplete` in that exact order, instead of matching them dynamically based on types, as Typer does.

Since Click 8, this functionality has been replaced by [`shell_complete`](https://click.palletsprojects.com/en/8.1.x/api/#click.ParamType.shell_complete), which still depends on the exact order of arguments for the callback function.

Expand Down
Loading