Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Allow Starlette 0.39.x, update the pin to >=0.37.2,<0.40.0 #12256

Closed
wants to merge 1 commit into from
Closed

⬆️ Allow Starlette 0.39.x, update the pin to >=0.37.2,<0.40.0 #12256

wants to merge 1 commit into from

Conversation

musicinmybrain
Copy link
Contributor

I ran the tests (with Starlette 0.39.0) and did not observe any regressions.

https://github.com/encode/starlette/releases/tag/0.39.0

@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 34ea016 at: https://0d648aef.fastapitiangolo.pages.dev

@Kludex
Copy link
Member

Kludex commented Sep 25, 2024

Thanks @musicinmybrain :)

@tiangolo
Copy link
Member

Thanks! This was included in #12431, so I'll close this one. Thanks for the help! 🚀

@tiangolo tiangolo closed this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees

@tiangolo tiangolo

Labels
reviewed upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@musicinmybrain @Kludex @tiangolo @alejsdev