Bumping Scala version to 2.11.8 to fix SI-9375 #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update this PR for latest version of Factorie and update |
|
Sure. The Build.scala in master currently says 1.2, should it say 1.3-SNAPSHOT? |
|
Oops, yes! Thanks for catching that. On Mon, Apr 25, 2016 at 12:44 PM Adam Pocock notifications@github.com
|
|
I pushed the merge commit, so it should be good. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the Scala version to 2.11.8, and removes the workaround we patched in to the java.io.Serialization of Attr objects.
It's not actually listed as being a bug fixed in Scala 2.11.8 due to a JIRA oddity, but the backport commit for it is scala/scala#4757 and I've verified the fix is in the binary from scala-lang.org.