Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HiTL Dashboard - Model Loss And Accuracy Visualization #1302

Open
wants to merge 5 commits into
base: hitl_dashboard_model_mng
Choose a base branch
from
Open

HiTL Dashboard - Model Loss And Accuracy Visualization #1302

wants to merge 5 commits into from

Conversation

mialsy
Copy link
Contributor

@mialsy mialsy commented Jul 23, 2022

Description

  • Updated frontend component to show the model line graph of loss and accuracy vs epoch.
  • Updated dependency of the hitl dashboard react app, added a recharts library.

Type of change

Please check the options that are relevant.

  • Bug fix (non-breaking change that fixes an issue)
  • Proposes a change (non-breaking change that isn't necessarily a bug)
  • Refactor
  • New feature (non-breaking change that adds a new functionality)
  • Breaking change (fix or feature that would break some existing functionality downstream)
  • This is a unit test
  • Documentation only change
  • Datasets Release
  • Models Release

Type of requested review

  • I want a thorough review of the implementation.
  • I want a high level review.
  • I want a deep design review.

Before and After

  • Demo:
    • demo_model_loss_acc_viz

Testing

Manually tested

Checklist:

  • I have performed manual end-to-end testing of the feature in my environment.
  • I have added Docstrings and comments to the code.
  • I have made changes to existing documentation where needed.
  • I have added tests that show that the PR is functional.
  • New and existing unit tests pass locally with my changes.
  • I have added relevant collaborators to review the PR before merge.
  • [Polymetis only] I ran on hardware (1) all scripts in tests/scripts, (2) asv benchmarks.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2022
ethan-carlson
ethan-carlson approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@ethan-carlson ethan-carlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for splitting this out.

One nit that I think would improve this component would be to either a) split loss and accuracy onto different y-axes or b) manually set the y-axis scale to be reasonable. This avoids the situation where a high loss (perhaps in epoch 0 or if we change our loss function) rescales the graph to the point that the accuracy line is not readable.

It's not strictly required but if you have time to make that change to this branch feel free to ask me to re-review and I'll stamp it.

@mialsy
Copy link
Contributor Author

mialsy commented Aug 17, 2022 •
edited
Loading

Hi Ethan

This is great, thank you for splitting this out.

One nit that I think would improve this component would be to either a) split loss and accuracy onto different y-axes or b) manually set the y-axis scale to be reasonable. This avoids the situation where a high loss (perhaps in epoch 0 or if we change our loss function) rescales the graph to the point that the accuracy line is not readable.

It's not strictly required but if you have time to make that change to this branch feel free to ask me to re-review and I'll stamp it.

Hi @ethan-carlson , there is a newer PR #1333 based on this PR that addressed the issue you mentioned here. I know you approved that PR before but Yuxuan had some new suggestions on that PR, so I am still working on that. Can I ask you for review on that PR (#1333 ) once I finish?

Once that's done, I will merge 1333 on 1302 and then merge 1302.

@ethan-carlson
Copy link
Contributor

Hi @ethan-carlson , there is a newer PR #1333 based on this PR that addressed the issue you mentioned here. I know you approved that PR before but Yuxuan had some new suggestions on that PR, so I am still working on that. Can I ask you for review on that PR (#1333 ) once I finish?

Once that's done, I will merge 1333 on 1302 and then merge 1302.

@mialsy Sure. For future reference I think it's easier to keep changes to the same content in a single PR, and then reference the updates in the description / point them out to reviewers.

@facebook-github-bot
Copy link

Hi @mialsy!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-carlson ethan-carlson ethan-carlson approved these changes

@kavyasrinet kavyasrinet Awaiting requested review from kavyasrinet

@aszlam aszlam Awaiting requested review from aszlam

@snyxan snyxan Awaiting requested review from snyxan

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mialsy @ethan-carlson @facebook-github-bot