Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HiTL Dashboard - View and Update Model Checksum #1301

Open
wants to merge 10 commits into
base: hitl_dashboard_model_viz
Choose a base branch
from
Open

HiTL Dashboard - View and Update Model Checksum #1301

wants to merge 10 commits into from

Conversation

mialsy
Copy link
Contributor

@mialsy mialsy commented Jul 22, 2022

Description

Added backend api and frontend components for viewing current model checksum and updating the checksum.

Type of change

Please check the options that are relevant.

  • Bug fix (non-breaking change that fixes an issue)
  • Proposes a change (non-breaking change that isn't necessarily a bug)
  • Refactor
  • New feature (non-breaking change that adds a new functionality)
  • Breaking change (fix or feature that would break some existing functionality downstream)
  • This is a unit test
  • Documentation only change
  • Datasets Release
  • Models Release

Type of requested review

  • I want a thorough review of the implementation.
  • I want a high level review.
  • I want a deep design review.

Before and After

Added new APIs:

  • get_model_checksum_by_name_n_agent
    • get the checksum for a specific model and agent
    • input:
      • model name
      • agent name
      • the valid combinations for model name and agent are:
        • nlu
        • perception locobot
        • perception craftassist
    • output: the checksum if model and agent combination are valid, and if checksum has been computed; otherwise error code
  • update_model_checksum_by_name_n_agent
    • update the checksum for a specific model and agent
    • input:
      • model name
      • agent name
      • the valid combinations for model name and agent are:
        • nlu
        • perception locobot
        • perception craftassist
    • output: an success code if update success

UI demo:

  • View and update checksum:
    - demo_view_n_update_model_checksum

Testing

Manually tested.

Checklist:

  • I have performed manual end-to-end testing of the feature in my environment.
  • I have added Docstrings and comments to the code.
  • I have made changes to existing documentation where needed.
  • I have added tests that show that the PR is functional.
  • New and existing unit tests pass locally with my changes.
  • I have added relevant collaborators to review the PR before merge.
  • [Polymetis only] I ran on hardware (1) all scripts in tests/scripts, (2) asv benchmarks.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2022
ethan-carlson
ethan-carlson reviewed Aug 17, 2022
View reviewed changes
droidlet/tools/artifact_scripts/tracked_checksums/locobot_perception.txt
@@ -1 +1 @@
0c6b0070ca1f30b1420c4db9259789c2d6442a3a
da39a3ee5e6b4b0d3255bfef95601890afd80709
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be checked in? We should only update the tracked checksums if there's an update to the associated artifacts.

droidlet/tools/artifact_scripts/tracked_checksums/nlu.txt
@@ -1 +1 @@
b15b887d3795140a5fab42a68d7369fcebf28e8c
da39a3ee5e6b4b0d3255bfef95601890afd80709
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

droidlet/tools/hitl/dashboard_app/backend/dashboard_server.py
@socketio.on(DASHBOARD_EVENT.UPDATE_MODEL_CHECKSUM.value)
def update_model_checksum(model_name, agent):
"""
update the checksum for a specific model and agent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be really clear what this does, both in this comment as well as maybe some text description shown to the user. "Update checksum" implies to me that we're updating it to a value we specify. This computes the checksum based on the artifacts currently in place on your branch, and then pushes that checksum to the tracked file.

@facebook-github-bot
Copy link

Hi @mialsy!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-carlson ethan-carlson ethan-carlson left review comments

@kavyasrinet kavyasrinet Awaiting requested review from kavyasrinet

@aszlam aszlam Awaiting requested review from aszlam

@snyxan snyxan Awaiting requested review from snyxan

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mialsy @facebook-github-bot @ethan-carlson