-
Notifications
You must be signed in to change notification settings - Fork 47.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blocks Fixture] fix broken fixture ServerComponent app #22151
[Blocks Fixture] fix broken fixture ServerComponent app #22151
Conversation
@gaearon I think you are best reviewer as a original author. |
Not sure why the |
@bvaughn Hello Brian👋 This is Sunday so could you have plenty rest time? 😀 I don't know this CI background though, looks like there is diff on git between original and fork. |
Running I rebased your branch on |
It's caused by an ESLint error causing the Try running Error: Failed to load config "react-app" to extend from.
Referenced from: fixtures/blocks/package.json |
Now that #22156 has landed, if you rebase on HEAD of |
82fb31a
to
0151d7e
Compare
After rebase and push for apply this fix, Still failed but showing ESLint message |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Summary
Since removed 'react/unstable-cache' entry point by above PR, Blocks not working with error on the next line.
import {createCache, CacheProvider} from 'react/unstable-cache';
Test Plan
I've planning adding test by Cypress.
Screen Capture
Screen.Recording.2021-08-22.at.4.17.49.mov