Skip to content

Commit

Permalink
Remove extra semis in RN (#1037)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1037

X-link: facebook/react-native#38068

## Changelog:
[Internal] - Remove extra semis called out by -Wextra-semi compiler flag

Reviewed By: cipolleschi

Differential Revision: D46765640

fbshipit-source-id: 9e9ff0cdeac49848ba31c1636f270fd730bf8acb
  • Loading branch information
John Ward authored and facebook-github-bot committed Jul 5, 2023
1 parent 82c05a6 commit d452bc3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions API/jsi/jsi/jsi.h
Original file line number Diff line number Diff line change
Expand Up @@ -1389,7 +1389,7 @@ class JSI_EXPORT Scope {
explicit Scope(Runtime& rt) : rt_(rt), prv_(rt.pushScope()) {}
~Scope() {
rt_.popScope(prv_);
};
}

Scope(const Scope&) = delete;
Scope(Scope&&) = delete;
Expand All @@ -1411,8 +1411,8 @@ class JSI_EXPORT Scope {
/// Base class for jsi exceptions
class JSI_EXPORT JSIException : public std::exception {
protected:
JSIException(){};
JSIException(std::string what) : what_(std::move(what)){};
JSIException() {}
JSIException(std::string what) : what_(std::move(what)) {}

public:
JSIException(const JSIException&) = default;
Expand Down Expand Up @@ -1453,7 +1453,7 @@ class JSI_EXPORT JSError : public JSIException {
/// Creates a JSError referring to new \c Error instance capturing current
/// JavaScript stack. The error message property is set to given \c message.
JSError(Runtime& rt, const char* message)
: JSError(rt, std::string(message)){};
: JSError(rt, std::string(message)) {}

/// Creates a JSError referring to a JavaScript Object having message and
/// stack properties set to provided values.
Expand Down

0 comments on commit d452bc3

Please sign in to comment.