Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Add support for async worker processes #2547

Merged
merged 7 commits into from
Oct 13, 2020
Merged

Add support for async worker processes #2547

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
15ea869
Allow WorkerProcess to be used for multiple jobs at the same time.
mikekap Sep 25, 2020
f9b38ca
Introduce a new `async` option to worker tools.
mikekap Sep 25, 2020
2486caf
Write some tests, fix some bugs
mikekap Sep 25, 2020
b2f3ebd
Add back license
mikekap Sep 29, 2020
11ca5fd
Update WorkerProcessPool.java
mikekap Sep 29, 2020
c767aba
Fix windows tests
mikekap Oct 2, 2020
fa1acbc
Code review feedback and clarifications, I hope
mikekap Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix windows tests 
Don't crash all of buck when a worker process fails.
  • Loading branch information
@mikekap
mikekap committed Oct 2, 2020
commit c767abaa5b4b5ab7f1443fd78541d64fad3d8b07
2 changes: 0 additions & 2 deletions src/com/facebook/buck/worker/WorkerProcess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,6 @@ private void readerLoop() {
return;
}
LOG.error(t, "Worker pool reader process failed");
Throwables.throwIfUnchecked(t);
throw new RuntimeException(t);
}
}

Expand Down
6 changes: 5 additions & 1 deletion test/com/facebook/buck/worker/FakeWorkerProcessProtocol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ public WorkerProcessProtocol.CommandResponse receiveNextCommandResponse() throws
if (isClosed) {
throw new RuntimeException("Closed");
}
return new WorkerProcessProtocol.CommandResponse(messageIds.poll(), 0);
try {
return new WorkerProcessProtocol.CommandResponse(messageIds.take(), 0);
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
}

@Override
Expand Down