Exec issues #832
Exec issues #832
Conversation
|
[merge] |
| return; | ||
|
|
||
| //If we already called onClosed() or onFailed() before, we need to abort. | ||
| if (explicitlyClosed.get() || closed.get() || !failed.compareAndSet(false, true) ) { |
There was a problem hiding this comment.
Calls to multiple atomics isn't in itself atomic... If you do need to do that, then consider AtomicReference to a holder object for the various states.
|
When I run the ExecExample，it occurs the error |
|
@ckanner: I think that as of kubernetes/kubernetes#49534 the kubectl proxy should have no issues with upgrade requests. Never tried it myself though. |
|
@iocanel I follow the issue kubernetes/kubernetes#49534 and set |
|
@ckanner: my understanding is that you also need a relatively new version of kubectl, no? |
|
@iocanel my kubectl version is v1.7.6 |
No description provided.