Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This replaces org.json with GSON. #1073

Merged
merged 14 commits into from
Sep 25, 2018
Merged

This replaces org.json with GSON. #1073

merged 14 commits into from
Sep 25, 2018

Conversation

rdifrango
Copy link
Contributor

@rdifrango rdifrango commented Aug 28, 2018 •
edited
Loading

This replaces org.json with GSON.

Resolves #1016
Resolves #1064

cc: @rhuss Sorry for the delay, I was able to make it work with GSON, not sure why @pepperbot is all over me though 😃

Signed-off-by: Ronald DiFrango ronald.difrango@capitalone.com

Ronald DiFrango added 6 commits August 27, 2018 21:57
This replaces org.json with GSON.
ea634f0 
Resolves fabric8io#1016
Resolves fabric8io#1064

Signed-off-by: Ronald DiFrango ronald.difrango@capitalone.com
Fixes things found by @pepperbot
20509a9 
Signed-off-by: Ronald DiFrango ronald.difrango@capitalone.com
Fixes things found by @pepperbot
50bdbad 
Signed-off-by: Ronald DiFrango ronald.difrango@capitalone.com
Fixes things found by @pepperbot
3e1a749 
Signed-off-by: Ronald DiFrango ronald.difrango@capitalone.com
Fixes things found by @pepperbot
3c7b629 
Signed-off-by: Ronald DiFrango ronald.difrango@capitalone.com
Fixes things found by @pepperbot
975da2d 
Signed-off-by: Ronald DiFrango ronald.difrango@capitalone.com
@ghost ghost deleted a comment from rdifrango Aug 28, 2018
@codecov
Copy link

codecov bot commented Aug 28, 2018 •
edited
Loading

Codecov Report

Merging #1073 into master will increase coverage by 0.07%.
The diff coverage is 58.02%.

@@             Coverage Diff              @@
##             master    #1073      +/-   ##
============================================
+ Coverage     51.77%   51.84%   +0.07%     
- Complexity     1414     1425      +11     
============================================
  Files           148      149       +1     
  Lines          7655     7684      +29     
  Branches       1149     1152       +3     
============================================
+ Hits           3963     3984      +21     
- Misses         3305     3308       +3     
- Partials        387      392       +5
Impacted Files Coverage Δ Complexity Δ
...ven/docker/access/hc/DockerAccessWithHcClient.java 13.62% <0%> (ø) 12 <0> (ø) ⬇️
...bric8/maven/docker/access/NetworkCreateConfig.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/io/fabric8/maven/docker/model/ExecDetails.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../docker/access/chunked/EntityStreamReaderUtil.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ocker/access/chunked/BuildJsonResponseHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../access/chunked/PullOrPushResponseJsonHandler.java 10.71% <0%> (ø) 1 <0> (ø) ⬇️
...abric8/maven/docker/model/NetworksListElement.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ric8/maven/docker/util/CredentialHelperClient.java 24.44% <0%> (ø) 3 <0> (ø) ⬇️
...fabric8/maven/docker/service/ImagePullManager.java 85.29% <100%> (ø) 10 <0> (ø) ⬇️
...ava/io/fabric8/maven/docker/access/UrlBuilder.java 67.22% <100%> (ø) 21 <0> (ø) ⬇️
... and 13 more

@rhuss
Copy link
Collaborator

rhuss commented Sep 4, 2018

Cool thanks ! I'm just back from PTO and hopefully can give it a review this week (quite some stuff to catch up though)

@rdifrango
Copy link
Contributor Author

@rhuss any chance to review this yet?

@rhuss
Copy link
Collaborator

rhuss commented Sep 16, 2018

Sorry for the delay. No, I had no chance to look at it but will do so soon, hopefully, next week. Please ping me again when I should miss that.

@rdifrango rdifrango mentioned this pull request Sep 20, 2018
Closed
@rhuss rhuss merged commit d51ca2a into fabric8io:master Sep 25, 2018
@rhuss
Copy link
Collaborator

rhuss commented Sep 25, 2018

@rdifrango thanks a lot, looks perfect ! And sorry for the delay ...

'hope you don't mind that I did a minor renaming from GsonBridge.toJsonObject(String) to JsonFactory.newJsonObject(String) as I think this is more intuitive and makes the used technology not so explicit.

Thanks again, you can expect a 0.27.0 release any time soon.

@rdifrango
Copy link
Contributor Author

@rhuss not at all and happy to have helped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdifrango @rhuss