refactor(internal/statesync): replace ticker with time.After(X) (co…

…metbft#2294) - Remove `defer` from `ticker.Stop()` inside the loop. - Manually call `ticker.Stop()` at necessary points in the loop to ensure tickers are stopped correctly after each iteration. --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
fabiotudone-da · Feb 12, 2024 · 0820cd5 · 0820cd5
1 parent 1d4b668
commit 0820cd5
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/internal/statesync/syncer.go b/internal/statesync/syncer.go
@@ -440,23 +440,18 @@ func (s *syncer) fetchChunks(ctx context.Context, snapshot *snapshot, chunks *ch
 		s.logger.Info("Fetching snapshot chunk", "height", snapshot.Height,
 			"format", snapshot.Format, "chunk", index, "total", chunks.Size())
 
-		ticker := time.NewTicker(s.retryTimeout)
-		defer ticker.Stop()
-
 		s.requestChunk(snapshot, index)
 
 		select {
 		case <-chunks.WaitFor(index):
 			next = true
 
-		case <-ticker.C:
+		case <-time.After(s.retryTimeout):
 			next = false
 
 		case <-ctx.Done():
 			return
 		}
-
-		ticker.Stop()
 	}
 }