LLVM 17 #840
Merged
LLVM 17 #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
force-pushed
the
llvm-17
branch
2 times, most recently
from
00c71ad to
da2ea93
Compare
csegarragonz
commented
Mar 5, 2024
| @@ -57,6 +61,8 @@ conan_cmake_install(PATH_OR_REFERENCE . | |||
| include(${CMAKE_CURRENT_BINARY_DIR}/conan_paths.cmake) | |||
|
|
|||
| find_package(Catch2 REQUIRED) | |||
| find_package(cppcodec REQUIRED) | |||
There was a problem hiding this comment.
Moved these two deps from faabric's CMake external projects, where they were not needed.
csegarragonz
force-pushed
the
llvm-17
branch
2 times, most recently
from
bf1cbf2 to
543844e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go again.
Dependent PRs:
To-Dos:
python funcs workingCloses #847
Closes #812
Closes #841