Different default documentation URL for different types of SDK

ezhaka · Feb 24, 2012 · f9cbfe7 · f9cbfe7
1 parent 5d8d56e
commit f9cbfe7
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 19 deletions.
diff --git a/.../intellij/openapi/roots/ui/configuration/libraryEditor/JavadocOrderRootTypeUIFactory.java b/.../intellij/openapi/roots/ui/configuration/libraryEditor/JavadocOrderRootTypeUIFactory.java
@@ -24,14 +24,13 @@
 import com.intellij.openapi.actionSystem.CustomShortcutSet;
 import com.intellij.openapi.fileChooser.FileChooserDescriptorFactory;
 import com.intellij.openapi.project.ProjectBundle;
-import com.intellij.openapi.projectRoots.JavaSdk;
-import com.intellij.openapi.projectRoots.JavaSdkVersion;
 import com.intellij.openapi.projectRoots.Sdk;
 import com.intellij.openapi.projectRoots.ui.SdkPathEditor;
 import com.intellij.openapi.projectRoots.ui.Util;
 import com.intellij.openapi.roots.JavadocOrderRootType;
 import com.intellij.openapi.roots.ui.OrderRootTypeUIFactory;
 import com.intellij.openapi.util.IconLoader;
+import com.intellij.openapi.util.text.StringUtil;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.ui.AnActionButton;
 import com.intellij.ui.AnActionButtonUpdater;
@@ -86,29 +85,14 @@ public boolean isEnabled(AnActionEvent e) {
     }
 
     private void onSpecifyUrlButtonClicked() {
-      VirtualFile virtualFile  = Util.showSpecifyJavadocUrlDialog(myPanel, getInitialValue());
+      final String defaultDocsUrl = mySdk == null ? "" : StringUtil.notNullize(mySdk.getSdkType().getDefaultDocumentationUrl(mySdk), "");
+      VirtualFile virtualFile  = Util.showSpecifyJavadocUrlDialog(myPanel, defaultDocsUrl);
       if(virtualFile != null){
         addElement(virtualFile);
         setModified(true);
         requestDefaultFocus();
         setSelectedRoots(new Object[]{virtualFile});
       }
     }
-
-    private String getInitialValue() {
-      if (mySdk != null) {
-        final JavaSdkVersion version = JavaSdk.getInstance().getVersion(mySdk);
-        if (version == JavaSdkVersion.JDK_1_5) {
-          return "http://download.oracle.com/javase/1.5.0/docs/api/";
-        }
-        else if (version == JavaSdkVersion.JDK_1_6) {
-          return "http://download.oracle.com/javase/6/docs/api/";
-        }
-        else if (version == JavaSdkVersion.JDK_1_7) {
-          return "http://download.oracle.com/javase/7/docs/api/";
-        }
-      }
-      return "";
-    }
   }
 }
diff --git a/java/java-impl/src/com/intellij/openapi/projectRoots/impl/JavaSdkImpl.java b/java/java-impl/src/com/intellij/openapi/projectRoots/impl/JavaSdkImpl.java
@@ -93,6 +93,21 @@ public Icon getIconForAddAction() {
     return ADD_ICON;
   }
 
+  @Nullable
+  public String getDefaultDocumentationUrl(final @NotNull Sdk sdk) {
+    final JavaSdkVersion version = getVersion(sdk);
+    if (version == JavaSdkVersion.JDK_1_5) {
+      return "http://download.oracle.com/javase/1.5.0/docs/api/";
+    }
+    else if (version == JavaSdkVersion.JDK_1_6) {
+      return "http://download.oracle.com/javase/6/docs/api/";
+    }
+    else if (version == JavaSdkVersion.JDK_1_7) {
+      return "http://download.oracle.com/javase/7/docs/api/";
+    }
+    return null;
+  }
+
   @Override
   public AdditionalDataConfigurable createAdditionalDataConfigurable(SdkModel sdkModel, SdkModificator sdkModificator) {
     return null;

diff --git a/platform/lang-api/src/com/intellij/openapi/projectRoots/SdkType.java b/platform/lang-api/src/com/intellij/openapi/projectRoots/SdkType.java
@@ -179,6 +179,11 @@ public String getHomeFieldLabel() {
     return ProjectBundle.message("sdk.configure.type.home.path", getPresentableName());
   }
 
+  @Nullable
+  public String getDefaultDocumentationUrl(final @NotNull Sdk sdk) {
+    return null;
+  }
+
   public static SdkType[] getAllTypes() {
     List<SdkType> allTypes = new ArrayList<SdkType>();
     Collections.addAll(allTypes, ApplicationManager.getApplication().getComponents(SdkType.class));

diff --git a/plugins/devkit/src/projectRoots/IdeaJdk.java b/plugins/devkit/src/projectRoots/IdeaJdk.java
@@ -475,4 +475,8 @@ public boolean isRootTypeApplicable(OrderRootType type) {
            type == JavadocOrderRootType.getInstance() ||
            type == AnnotationOrderRootType.getInstance();
   }
+
+  public String getDefaultDocumentationUrl(final @NotNull Sdk sdk) {
+    return JavaSdk.getInstance().getDefaultDocumentationUrl(sdk);
+  }
 }