fix(fs): Major and minor device on MacOS #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfxegbert
force-pushed
the
mac-major-device-fix
branch
from
f087927 to
94bd314
Compare
cfxegbert
force-pushed
the
mac-major-device-fix
branch
from
94bd314 to
24a89a5
Compare
9glenda
approved these changes
Sep 20, 2023
cafkafk
reviewed
Sep 20, 2023
There was a problem hiding this comment.
I do not have a linux box to test on right now. Someone please test.
Output of cargo run --release -- -l /dev/ > changes.txt; exa -l /dev/ > old.txt; diff changes.txt old.txt;
8c8
< lrwxrwxrwx 141T root 14 Sep 06:58 core -> /proc/kcore
---
> lrwxrwxrwx 11 root 14 Sep 06:58 core -> /proc/kcore
16c16
< lrwxrwxrwx - root 14 Sep 06:58 fd -> /proc/self/fd
---
> lrwxrwxrwx 13 root 14 Sep 06:58 fd -> /proc/self/fd
37c37
< lrwxrwxrwx 0 root 14 Sep 06:58 log -> /run/systemd/journal/dev-log
---
> lrwxrwxrwx 28 root 14 Sep 06:58 log -> /run/systemd/journal/dev-log
66,67c66,67
< lrwxrwxrwx 8,1 root 14 Sep 06:58 root -> sda1
< lrwxrwxrwx 253,0 root 14 Sep 06:58 rtc -> rtc0
---
> lrwxrwxrwx 4 root 14 Sep 06:58 root -> sda1
> lrwxrwxrwx 4 root 14 Sep 06:58 rtc -> rtc0
90,92c90,92
< lrwxrwxrwx 136,4 root 14 Sep 06:58 stderr -> /proc/self/fd/2
< lrwxrwxrwx 136,4 root 14 Sep 06:58 stdin -> /proc/self/fd/0
< lrwxrwxrwx 0 root 14 Sep 06:58 stdout -> /proc/self/fd/1
---
> lrwxrwxrwx 15 root 14 Sep 06:58 stderr -> /proc/self/fd/2
> lrwxrwxrwx 15 root 14 Sep 06:58 stdin -> /proc/self/fd/0
> lrwxrwxrwx 15 root 14 Sep 06:58 stdout -> /proc/self/fd/1
Also glad you're looking into this, had to give up because I didn't have a Mac #13
Why is the old one returning the major/minor of the followed linked and the new one returning the link? I think the old one is wrong. |
cafkafk
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not have a linux box to test on right now. Someone please test.