Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default settings to configurations #4995

Merged
merged 55 commits into from
Feb 27, 2020
Merged

Default settings to configurations #4995

Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
619dae9
fix grad_clip naming
svlandeg Feb 4, 2020
32a1f08
cleaning up pretrained_vectors out of cfg
svlandeg Feb 4, 2020
a29ea7b
further refactoring Model init's
svlandeg Feb 4, 2020
7c9aebe
Merge branch 'bugfix/optimizer' into feature/static-vectors
svlandeg Feb 5, 2020
1f390a1
move Model building out of pipes
svlandeg Feb 5, 2020
1ee119c
further refactor to require a model config when creating a pipe
svlandeg Feb 5, 2020
fad5862
small fixes
svlandeg Feb 5, 2020
3082df4
making cfg in nn_parser more consistent
svlandeg Feb 5, 2020
f852d7d
fixing nr_class for parser
svlandeg Feb 5, 2020
d66c65a
fixing nn_parser's nO
svlandeg Feb 6, 2020
5b4c035
fix printing of loss
svlandeg Feb 6, 2020
6725b19
architectures in own file per type, consistent naming
svlandeg Feb 6, 2020
1133968
convenience methods default_tagger_config and default_tok2vec_config
svlandeg Feb 6, 2020
b85aecf
let create_pipe access default config if available for that component
svlandeg Feb 6, 2020
301a5fb
default_parser_config
svlandeg Feb 6, 2020
0278c14
move defaults to separate folder
svlandeg Feb 6, 2020
ad8ff6e
allow reading nlp from package or dir with argument 'name'
svlandeg Feb 7, 2020
e06dd68
architecture spacy.VocabVectors.v1 to read static vectors from file
svlandeg Feb 7, 2020
ade2d37
cleanup
svlandeg Feb 7, 2020
2412db9
default configs for nel, textcat, morphologizer, tensorizer
svlandeg Feb 7, 2020
8ab20b6
fix imports
svlandeg Feb 7, 2020
359faba
fixing unit tests
svlandeg Feb 7, 2020
215a282
fixes and clean up
svlandeg Feb 10, 2020
36371b4
fixing defaults, nO, fix unit tests
svlandeg Feb 10, 2020
9438264
restore parser IO
svlandeg Feb 10, 2020
8857718
fix IO
svlandeg Feb 10, 2020
0f12be6
'fix' serialization test
svlandeg Feb 10, 2020
4b3cdf4
add *.cfg to manifest
svlandeg Feb 10, 2020
517c06c
fix example configs with additional arguments
svlandeg Feb 10, 2020
98326c2
replace Morpohologizer with Tagger
svlandeg Feb 11, 2020
f67c7fa
add IO bit when testing overfitting of tagger (currently failing)
svlandeg Feb 11, 2020
5e7d0b2
fix IO - don't initialize when reading from disk
svlandeg Feb 11, 2020
c7be83f
expand overfitting tests to also check IO goes OK
svlandeg Feb 11, 2020
84efef2
remove dropout from HashEmbed to fix Tagger performance
svlandeg Feb 11, 2020
a9037ea
add defaults for sentrec
svlandeg Feb 11, 2020
e48a5a1
fix merge conflict in manifest
svlandeg Feb 12, 2020
3d368b8
update thinc
svlandeg Feb 18, 2020
05c9184
merge develop into branch
svlandeg Feb 25, 2020
df47926
always pass a Model instance to a Pipe
svlandeg Feb 26, 2020
a518868
fix piped_added statement
svlandeg Feb 26, 2020
817578b
remove obsolete W029
svlandeg Feb 26, 2020
add4105
remove obsolete errors
svlandeg Feb 26, 2020
403f57c
Merge remote-tracking branch 'upstream/develop' into feature/static-v…
svlandeg Feb 26, 2020
3c285f5
restore byte checking tests (work again)
svlandeg Feb 26, 2020
492e941
clean up test
svlandeg Feb 26, 2020
c7a0329
further test cleanup
svlandeg Feb 26, 2020
10a50c7
convert from config to Model in create_pipe
svlandeg Feb 27, 2020
1deaffd
bring back error when component is not initialized
svlandeg Feb 27, 2020
79fdcd8
cleanup
svlandeg Feb 27, 2020
b614adb
remove calls for nlp2.begin_training
svlandeg Feb 27, 2020
80e5e2f
use thinc.api in imports
svlandeg Feb 27, 2020
2c96c24
allow setting charembed's nM and nC
svlandeg Feb 27, 2020
f69f8db
fix for hardcoded nM/nC + unit test
svlandeg Feb 27, 2020
a673ba3
formatting fixes
svlandeg Feb 27, 2020
14da14c
trigger build
svlandeg Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove obsolete W029
  • Loading branch information
@svlandeg
svlandeg committed Feb 26, 2020
commit 817578b6469a15543c57e9a6da0fed44a124ac55
2 changes: 0 additions & 2 deletions spacy/errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ class Warnings(object):
W028 = ("Skipping unsupported morphological feature(s): {feature}. "
"Provide features as a dict {{\"Field1\": \"Value1,Value2\"}} or "
"string \"Field1=Value1,Value2|Field2=Value3\".")
W029 = ("No Model config was provided to create the '{name}' component, "
"so a default configuration was used.")


@add_codes
Expand Down