Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl <xdr:twoCellAnchor editAs=oneCell> #407

Merged
merged 7 commits into from
Nov 20, 2017
Merged

Impl <xdr:twoCellAnchor editAs=oneCell> #407

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7c2132
Impl <xdr:twoCellAnchor editAs=oneCell>
Ockejanssen Sep 21, 2017
818c75b
EUDEV-7310 need Jenkins job, should run build before publish - adapted
Sep 28, 2017
ae5e3d4
EUDEV-7310 better be scoped - adapted
Sep 28, 2017
19204a6
Revert "EUDEV-7310 better be scoped - adapted"
Sep 29, 2017
dffc1cc
Revert "EUDEV-7310 need Jenkins job, should run build before publish …
Sep 29, 2017
6192fcb
add missing braces - fixed
Ockejanssen Oct 12, 2017
7b43c68
add missing doc - fixed
Ockejanssen Oct 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add missing doc - fixed
  • Loading branch information
@Ockejanssen
Ockejanssen committed Oct 12, 2017
commit 7b43c68593278743be51e20009085a7538256cbb
27 changes: 14 additions & 13 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ npm install exceljs
Contributions are very welcome! It helps me know what features are desired or what bugs are causing the most pain.

I have just one request; If you submit a pull request for a bugfix, please add a unit-test or integration-test (in the spec folder) that catches the problem.
Even a PR that just has a failing test is fine - I can analyse what the test is doing and fix the code from that.
Even a PR that just has a failing test is fine - I can analyse what the test is doing and fix the code from that.

To be clear, all contributions added to this library will be included in the library's MIT licence.

Expand Down Expand Up @@ -168,7 +168,7 @@ The Workbook views controls how many separate windows Excel will open when viewi
```javascript
workbook.views = [
{
x: 0, y: 0, width: 10000, height: 20000,
x: 0, y: 0, width: 10000, height: 20000,
firstSheet: 0, activeTab: 1, visibility: 'visible'
}
]
Expand Down Expand Up @@ -265,8 +265,8 @@ var worksheetWriter = workbookWriter.addSheet('sheet', {

// adjust pageSetup settings afterwards
worksheet.pageSetup.margins = {
left: 0.7, right: 0.7,
top: 0.75, bottom: 0.75,
left: 0.7, right: 0.7,
top: 0.75, bottom: 0.75,
header: 0.3, footer: 0.3
};

Expand Down Expand Up @@ -306,9 +306,9 @@ worksheet.pageSetup.printTitlesRow = '1:3';

| Name | Value |
| ----------------------------- | --------- |
| Letter | undefined |
| Letter | undefined |
| Legal | 5 |
| Executive | 7 |
| Executive | 7 |
| A4 | 9 |
| A5 | 11 |
| B5 (JIS) | 13 |
Expand Down Expand Up @@ -473,9 +473,9 @@ dobCol.eachCell({ includeEmpty: true }, function(cell, rowNumber) {
worksheet.spliceColumns(3,2);

// remove one column and insert two more.
// Note: columns 4 and above will be shifted right by 1 column.
// Also: If the worksheet has more rows than values in the colulmn inserts,
// the rows will still be shifted as if the values existed
// Note: columns 4 and above will be shifted right by 1 column.
// Also: If the worksheet has more rows than values in the colulmn inserts,
// the rows will still be shifted as if the values existed
var newCol3Values = [1,2,3,4,5];
var newCol4Values = ['one', 'two', 'three', 'four', 'five'];
worksheet.spliceColumns(3, 1, newCol3Values, newCol4Values);
Expand Down Expand Up @@ -586,7 +586,7 @@ row.eachCell({ includeEmpty: true }, function(cell, colNumber) {
worksheet.spliceRows(4,3);

// remove one row and insert two more.
// Note: rows 4 and below will be shifted down by 1 row.
// Note: rows 4 and below will be shifted down by 1 row.
var newRow3Values = [1,2,3,4,5];
var newRow4Values = ['one', 'two', 'three', 'four', 'five'];
worksheet.spliceRows(3, 1, newRow3Values, newRow4Values);
Expand Down Expand Up @@ -1084,6 +1084,7 @@ expect(worksheet.getColumn(3).collapsed).to.be.false;
Adding images to a worksheet is a two-step process.
First, the image is added to the workbook via the addImage() function which will also return an imageId value.
Then, using the imageId, the image can be added to the worksheet either as a tiled background or covering a cell range.
The cell range can also have the property editAs with the value 'oneCell' which allows to set the anchor to cell.

Note: As of this version, adjusting or transforming the image is not supported.

Expand Down Expand Up @@ -1240,7 +1241,7 @@ The CSV parser uses [fast-csv](https://www.npmjs.com/package/fast-csv) to read t

Dates are parsed using the npm module [moment](https://www.npmjs.com/package/moment).
If no dateFormats are supplied, the following are used:

* moment.ISO_8601
* 'MM-DD-YYYY'
* 'YYYY-MM-DD'
Expand Down Expand Up @@ -1531,7 +1532,7 @@ A shared formula can be assigned to a cell using a new value form:
worksheet.getCell('B3').value = { sharedFormula: 'A3', result: 10 };
```

This specifies that the cell B3 is a formula that will be derived from the formula in
This specifies that the cell B3 is a formula that will be derived from the formula in
A3 and its result is 10.

The formula convenience getter will translate the formula in A3 to what it should be in B3:
Expand Down Expand Up @@ -1643,7 +1644,7 @@ To mitigate this the following two changes were added to 0.3.0:

ExcelJS now supports dependency injection for the promise library.
You can restore Bluebird promises by including the following code in your module...

```javascript
ExcelJS.config.setValue('promise', require('bluebird'));
```
Expand Down