Modified Mac build fix for new binding.gyp structure

ewr · Oct 22, 2015 · 6ffdb94 · 6ffdb94
1 parent 403caaf
commit 6ffdb94
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 20 deletions.
diff --git a/binding.gyp b/binding.gyp
@@ -73,16 +73,6 @@
          ]
         ]
       }],
-      ['OS=="mac"', {
-        'xcode_settings': {
-          'MACOSX_DEPLOYMENT_TARGET': '10.9',
-          'OTHER_CFLAGS': [
-            '-fno-strict-aliasing',
-            '-std=c++11',
-            '-stdlib=libc++'
-          ]
-        }
-      }]
     ]
   },
   'targets': [
@@ -134,6 +124,16 @@
         'src/core/support/time_win32.c',
         'src/core/support/tls_pthread.c',
       ],
+      "conditions": [
+        ['OS == "mac"', {
+          'xcode_settings': {
+            'MACOSX_DEPLOYMENT_TARGET': '10.9',
+            'OTHER_CFLAGS': [
+              '-stdlib=libc++'
+            ]
+          }
+        }]
+      ],
     },
     {
       'target_name': 'grpc',
@@ -292,6 +292,16 @@
         'src/core/census/operation.c',
         'src/core/census/tracing.c',
       ],
+      "conditions": [
+        ['OS == "mac"', {
+          'xcode_settings': {
+            'MACOSX_DEPLOYMENT_TARGET': '10.9',
+            'OTHER_CFLAGS': [
+              '-stdlib=libc++'
+            ]
+          }
+        }]
+      ],
     },
     {
       'include_dirs': [

diff --git a/templates/binding.gyp.template b/templates/binding.gyp.template
@@ -75,16 +75,6 @@
            ]
           ]
         }],
-        ['OS=="mac"', {
-          'xcode_settings': {
-            'MACOSX_DEPLOYMENT_TARGET': '10.9',
-            'OTHER_CFLAGS': [
-              '-fno-strict-aliasing',
-              '-std=c++11',
-              '-stdlib=libc++'
-            ]
-          }
-        }]
       ]
     },
     'targets': [
@@ -104,6 +94,16 @@
           '${source}',
           % endfor
         ],
+        "conditions": [
+          ['OS == "mac"', {
+            'xcode_settings': {
+              'MACOSX_DEPLOYMENT_TARGET': '10.9',
+              'OTHER_CFLAGS': [
+                '-stdlib=libc++'
+              ]
+            }
+          }]
+        ],
       },
       % endif
       % endfor